[DataGrid] Replace eval with new Function #11557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
the
component: data grid
|
Deploy preview: https://deploy-preview-11557--material-ui-x.netlify.app/ |
romgrk
reviewed
Jan 3, 2024
romgrk
reviewed
Jan 3, 2024
packages/grid/x-data-grid/src/hooks/features/filter/gridFilterUtils.ts
Outdated
Show resolved
Hide resolved
romgrk
reviewed
Jan 3, 2024
packages/grid/x-data-grid/src/hooks/features/filter/gridFilterUtils.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Rom Grk <romgrk@users.noreply.github.com> Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
romgrk
reviewed
Jan 3, 2024
Comment on lines
294
to
291
| const filterItem: GridFilterItemApplierNotAggregated = (row, shouldApplyItem) => { | ||
| return filterItemCore(apiRef.current.getRowId, appliers, row, shouldApplyItem); | ||
| }; | ||
| filterItemsApplierId += 1; | ||
|
|
||
| return filterItem; | ||
| return (row, shouldApplyItem) => filterItemCore(appliers, row, shouldApplyItem); |
There was a problem hiding this comment.
Sometimes I like assigning functions to a variable because it gives a better debugging experience, the stack entry would read filterItem - .../gridFilterUtils.js:294 instead of (anonymous) - .../gridFilterUtils.js:291. It's useful when stepping through code but also when collecting performance profiles. With this change I'm also not sure what the name of filterItemCore becomes.
It's fine to leave as it is, but just fyi.
romgrk
approved these changes
Jan 3, 2024
oliviertassinari
force-pushed
the
avoid-eval
branch
from
18bf330 to
0a03dd4
Compare
oliviertassinari
force-pushed
the
avoid-eval
branch
from
0a03dd4 to
e6095c3
Compare
|
@romgrk thanks for the reviews. |
cherniavskii
added
feature: Filtering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was curious if we could improve this logic:
getRowIdwas removed in [DataGrid] Remove legacy filtering API #10897, no need to provide it as an argument anymore.atob('ZXZhbA=='), it feels like obfuscation and fix @mui/x-data-grid-premium "ReferenceError: atob is not defined" #11046eval and new Function are by default sloopy https://2ality.com/2014/01/eval.html, made it strict.