Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Allow to change reset text in columns management panel #12972

Merged
merged 3 commits into from
May 2, 2024
Merged

[DataGrid] Allow to change reset text in columns management panel #12972

merged 3 commits into from
May 2, 2024

Conversation

MBilalShafi
Copy link
Member

Fixes #12970

@MBilalShafi MBilalShafi added component: data grid This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature labels May 2, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 2, 2024
@mui-bot

This comment was marked as off-topic.

Sign in to view
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 2, 2024
@MBilalShafi MBilalShafi requested a review from michelengelen May 2, 2024 12:18
@michelengelen
Copy link
Member

On a side note... did we ever think about using a translation tool like Lokalise?

@MBilalShafi
Copy link
Member Author

MBilalShafi commented May 2, 2024 •
edited
Loading

On a side note... did we ever think about using a translation tool like Lokalise?

Seems interesting, I haven't checked it before. As far as I understand, it helps to speed up/smootlen the translation process. Wouldn't it be more helpful if the translations were done in-house, for us, it's mostly community-driven. Wdyt?

@MBilalShafi MBilalShafi merged commit 8f03743 into mui:master May 2, 2024
17 checks passed
@MBilalShafi MBilalShafi deleted the reset-text-l10n branch May 2, 2024 13:05
@michelengelen
Copy link
Member

On a side note... did we ever think about using a translation tool like Lokalise?

Seems interesting, I haven't checked it before. As far as I understand, it helps to speed up/smootlen the translation process. Wouldn't it be more helpful if the translations were done in-house, for us, it's mostly community-driven. Wdyt?

Yes, i am not sure about this specific tool, but there are tools out there that let the community contribute as well. At Mattermost we used weblate ... anyone can access it (with an account of course)

@Crihojames Crihojames mentioned this pull request Jun 1, 2024
Open
@joaosreis joaosreis mentioned this pull request Jun 5, 2024
Merged
1 task
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@MBilalShafi @DungTiger
[DataGrid] Allow to change reset text in columns management panel (mu…
5c846da 
…i#12972)
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@MBilalShafi @thomasmoon
[DataGrid] Allow to change reset text in columns management panel (mu…
16eb96a 
…i#12972)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelengelen michelengelen michelengelen approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can not change "Reset" button text
3 participants
@MBilalShafi @mui-bot @michelengelen