Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Improve Portuguese (pt-PT) locale #13348

Merged
merged 2 commits into from
Jun 17, 2024
Merged

[l10n] Improve Portuguese (pt-PT) locale #13348

merged 2 commits into from
Jun 17, 2024

Conversation

joaosreis
Copy link
Contributor

@mui-bot
Copy link

mui-bot commented Jun 2, 2024 •
edited by arthurbalduini
Loading

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-13348--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against b2845cc

@joaosreis joaosreis changed the title Update DataGrid ptPT locale [l10n] Update DataGrid Portuguese (pt-PT) locale Jun 2, 2024
@zannager zannager added the l10n localization label Jun 3, 2024
arthurbalduini
arthurbalduini approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@arthurbalduini arthurbalduini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixe ! 😄

@LukasTy LukasTy added the component: data grid This is the name of the generic UI component, not the React module! label Jun 5, 2024
@LukasTy LukasTy changed the title [l10n] Update DataGrid Portuguese (pt-PT) locale [l10n] Improve Portuguese (pt-PT) locale Jun 5, 2024
arthurbalduini
arthurbalduini reviewed Jun 5, 2024
View reviewed changes
packages/x-data-grid/src/locales/ptPT.ts
columnsManagementSearchTitle: 'Procurar',
columnsManagementNoColumns: 'Sem colunas',
columnsManagementShowHideAllText: 'Mostrar/Ocultar Todas',
columnsManagementReset: 'Repor',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe columnsManagementReset is omitted for all locales.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it because the field is recent (#12972) and maybe no else translated it yet on other locales?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, can you confirm it @MBilalShafi ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the columnsManagementReset key is supposed to be translated just like every other.

@flaviendelangle flaviendelangle merged commit c76cbf6 into mui:master Jun 17, 2024
19 checks passed
This was referenced Jul 13, 2024
Open
Open
@alhabib5565 alhabib5565 mentioned this pull request Jul 14, 2024
Open
@KotoneZQ KotoneZQ mentioned this pull request Jul 18, 2024
Open
This was referenced Jul 20, 2024
Open
Open
@Carment14tham Carment14tham mentioned this pull request Jul 20, 2024
Open
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@joaosreis @DungTiger
[l10n] Improve Portuguese (pt-PT) locale (mui#13348)
0f38d43
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@joaosreis @thomasmoon
[l10n] Improve Portuguese (pt-PT) locale (mui#13348)
a6489a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurbalduini arthurbalduini arthurbalduini approved these changes

@MBilalShafi MBilalShafi MBilalShafi left review comments

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@joaosreis @mui-bot @MBilalShafi @arthurbalduini @flaviendelangle @LukasTy @zannager