Bump internal packages #13479
Bump internal packages #13479
Conversation
LukasTy
added
dependencies
|
Deploy preview: https://deploy-preview-13479--material-ui-x.netlify.app/ |
| @@ -62,7 +62,7 @@ | |||
| "react-dom": "^17.0.0 || ^18.0.0" | |||
| }, | |||
| "devDependencies": { | |||
| "@mui/internal-test-utils": "1.0.0", | |||
| "@mui/internal-test-utils": "^1.0.1", | |||
There was a problem hiding this comment.
Do you know why we define this one in each package and not just at the root?
There was a problem hiding this comment.
Maybe because mui/material-ui has it set up like that... 🤷 🙈
Not sure, I also don't see too much point in that.
Maybe @michaldudak could clarify as he introduced it with #12880.
I've pushed a commit keeping only root dependency to see if everything sill works after that: 7a74141.
There was a problem hiding this comment.
Because it's used in each of these packages. It may not be a big deal for devDependencies, but it's a good practice to define dependencies where they are used. This way packages can be more self-sustained and not implicitly depend on anything around them.
There was a problem hiding this comment.
I appreciate the clarification.
Personally, I don't have a strong preference on this, but I understand the position, especially if at some point the package would have to be moved from the monorepo context, there would be one less thing to adjust.
WDYT @flaviendelangle?
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
@mui/internal-*packages.mui/code-infra how would you suggest handling these package bumping/syncing while the core repo is in thenextphase? 🤔All the new packages are released with the
nexttag, thus, they will not be bumped byrenovate. 🤷Disregard the ☝️ comment as it seems that renovate doesn't look at the tag, but bumps to the highest available
semvernumber.The only reason it didn't bump all packages is the concurrent PRs limit of 30, which we could consider increasing. 🤔
mui-x/renovate.json
Line 108 in 29b9131