Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump internal packages #13479

Merged
merged 6 commits into from
Jun 17, 2024
Merged

Bump internal packages #13479

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3d5e90f
Bump internal packages
LukasTy Jun 14, 2024
00564b6
Bump `@mui/internal-docs-utils`
LukasTy Jun 14, 2024
de15f1b
Bump `@mui/internal-scripts`
LukasTy Jun 14, 2024
7a74141
Keep only root `@mui/internal-test-utils` dependency
LukasTy Jun 14, 2024
e262511
Revert "Keep only root `@mui/internal-test-utils` dependency"
LukasTy Jun 17, 2024
1e79a0f
Merge remote-tracking branch 'upstream/master' into bump-internal-pac…
LukasTy Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@
"devDependencies": {
"@babel/plugin-transform-react-constant-elements": "^7.24.7",
"@babel/preset-typescript": "^7.24.7",
"@mui/internal-docs-utils": "^1.0.4",
"@mui/internal-scripts": "^1.0.3",
"@mui/internal-docs-utils": "^1.0.7",
"@mui/internal-scripts": "^1.0.10",
"@types/chance": "^1.1.6",
"@types/d3-scale": "^4.0.8",
"@types/doctrine": "^0.0.9",
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@
"@emotion/styled": "^11.11.5",
"@mnajdova/enzyme-adapter-react-18": "^0.2.0",
"@mui/icons-material": "^5.15.19",
"@mui/internal-markdown": "^1.0.4",
"@mui/internal-test-utils": "1.0.0",
"@mui/internal-markdown": "^1.0.5",
"@mui/internal-test-utils": "^1.0.1",
"@mui/material": "^5.15.19",
"@mui/monorepo": "github:mui/material-ui#22c5206a9e8191b2f81131d6978a0958e55b7032",
"@mui/utils": "^5.15.14",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-charts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
}
},
"devDependencies": {
"@mui/internal-test-utils": "1.0.0",
"@mui/internal-test-utils": "^1.0.1",
"@react-spring/core": "^9.7.3",
"@react-spring/shared": "^9.7.3",
"@types/d3-color": "^3.1.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-data-grid-premium/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"react-dom": "^17.0.0 || ^18.0.0"
},
"devDependencies": {
"@mui/internal-test-utils": "1.0.0",
"@mui/internal-test-utils": "^1.0.1",
"@types/prop-types": "^15.7.12",
"date-fns": "^2.30.0",
"rimraf": "^5.0.7"
Expand Down
2 changes: 1 addition & 1 deletion packages/x-data-grid-pro/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"react-dom": "^17.0.0 || ^18.0.0"
},
"devDependencies": {
"@mui/internal-test-utils": "1.0.0",
"@mui/internal-test-utils": "^1.0.1",
"@types/prop-types": "^15.7.12",
"rimraf": "^5.0.7"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/x-data-grid/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"react-dom": "^17.0.0 || ^18.0.0"
},
"devDependencies": {
"@mui/internal-test-utils": "1.0.0",
"@mui/internal-test-utils": "^1.0.1",
"@mui/joy": "5.0.0-beta.32",
"@mui/types": "^7.2.14",
"@types/prop-types": "^15.7.12",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-date-pickers-pro/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
}
},
"devDependencies": {
"@mui/internal-test-utils": "1.0.0",
"@mui/internal-test-utils": "^1.0.1",
"@types/luxon": "^3.4.2",
"@types/prop-types": "^15.7.12",
"date-fns": "^2.30.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-date-pickers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
}
},
"devDependencies": {
"@mui/internal-test-utils": "1.0.0",
"@mui/internal-test-utils": "^1.0.1",
"@types/luxon": "^3.4.2",
"@types/moment-hijri": "^2.1.4",
"@types/moment-jalaali": "^0.7.9",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-license/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"react": "^17.0.0 || ^18.0.0"
},
"devDependencies": {
"@mui/internal-test-utils": "1.0.0",
"@mui/internal-test-utils": "^1.0.1",
"rimraf": "^5.0.7"
},
"engines": {
Expand Down
2 changes: 1 addition & 1 deletion packages/x-tree-view-pro/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"react-dom": "^17.0.0 || ^18.0.0"
},
"devDependencies": {
"@mui/internal-test-utils": "1.0.0",
"@mui/internal-test-utils": "^1.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why we define this one in each package and not just at the root?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe because mui/material-ui has it set up like that... 🤷 🙈
Not sure, I also don't see too much point in that.
Maybe @michaldudak could clarify as he introduced it with #12880.

I've pushed a commit keeping only root dependency to see if everything sill works after that: 7a74141.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's used in each of these packages. It may not be a big deal for devDependencies, but it's a good practice to define dependencies where they are used. This way packages can be more self-sustained and not implicitly depend on anything around them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the clarification.
Personally, I don't have a strong preference on this, but I understand the position, especially if at some point the package would have to be moved from the monorepo context, there would be one less thing to adjust.
WDYT @flaviendelangle?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine for me

"rimraf": "^5.0.7"
},
"engines": {
Expand Down
2 changes: 1 addition & 1 deletion packages/x-tree-view/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"react-dom": "^17.0.0 || ^18.0.0"
},
"devDependencies": {
"@mui/internal-test-utils": "1.0.0",
"@mui/internal-test-utils": "^1.0.1",
"@types/prop-types": "^15.7.12",
"rimraf": "^5.0.7"
},
Expand Down
78 changes: 39 additions & 39 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading