Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fields] Do not apply digit editing when pressing Space #13510

Merged
merged 1 commit into from
Jun 17, 2024
Merged

[fields] Do not apply digit editing when pressing Space #13510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/x-date-pickers/src/TimeField/tests/editing.TimeField.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,6 +621,13 @@ describe('<TimeField /> - Editing', () => {
keyStrokes: [{ value: 'p', expected: 'PM' }],
});
});

it('should not edit when pressing the Space key', () => {
testFieldChange({
format: adapter.formats.hours24h,
keyStrokes: [{ value: ' ', expected: 'hh' }],
});
});
});

describeAdapters(
Expand Down
3 changes: 2 additions & 1 deletion packages/x-date-pickers/src/internals/hooks/useField/useField.utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@ export const applyLocalizedDigits = (valueStr: string, localizedDigits: string[]

export const isStringNumber = (valueStr: string, localizedDigits: string[]) => {
const nonLocalizedValueStr = removeLocalizedDigits(valueStr, localizedDigits);
return !Number.isNaN(Number(nonLocalizedValueStr));
// `Number(' ')` returns `0` even if ' ' is not a valid number.
return nonLocalizedValueStr !== ' ' && !Number.isNaN(Number(nonLocalizedValueStr));
};

/**
Expand Down
Loading