Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fields] Do not apply digit editing when pressing Space #13510

Merged
merged 1 commit into from
Jun 17, 2024
Merged

[fields] Do not apply digit editing when pressing Space #13510

merged 1 commit into from
Jun 17, 2024

Conversation

flaviendelangle
Copy link
Member

Fixes #9014

@flaviendelangle flaviendelangle self-assigned this Jun 17, 2024
@flaviendelangle flaviendelangle added bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! labels Jun 17, 2024
@flaviendelangle flaviendelangle marked this pull request as ready for review June 17, 2024 08:15
@mui-bot
Copy link

mui-bot commented Jun 17, 2024

Deploy preview: https://deploy-preview-13510--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 2eb1076

@flaviendelangle flaviendelangle changed the title [fields] Do not apply digit edition when pressing Space [fields] Do not apply digit edition when pressing <kbd>Space</kbd> Jun 17, 2024
@flaviendelangle flaviendelangle changed the title [fields] Do not apply digit edition when pressing <kbd>Space</kbd> [fields] Do not apply digit edition when pressing Space Jun 17, 2024
@flaviendelangle flaviendelangle changed the title [fields] Do not apply digit edition when pressing Space [fields] Do not apply digit editing when pressing Space Jun 17, 2024
LukasTy
LukasTy approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the fix! 🙏
WDYT, should we cherry-pick to v6? 🤔
Looks like a pretty annoying bug. 🤷

@LukasTy LukasTy added the feature: Keyboard editing Related to the pickers keyboard edition label Jun 17, 2024
@flaviendelangle flaviendelangle added the needs cherry-pick The PR should be cherry-picked to master after merge label Jun 17, 2024
@flaviendelangle flaviendelangle merged commit 3dd5071 into mui:master Jun 17, 2024
20 of 21 checks passed
@flaviendelangle flaviendelangle deleted the fields-space-digit branch June 17, 2024 10:35
github-actions bot pushed a commit that referenced this pull request Jun 17, 2024
@flaviendelangle @web-flow
[fields] Do not apply digit editing when pressing Space (#13510)
79b60ea
@github-actions github-actions bot mentioned this pull request Jun 17, 2024
Merged
This was referenced Jul 13, 2024
Open
Open
@alhabib5565 alhabib5565 mentioned this pull request Jul 14, 2024
Open
@KotoneZQ KotoneZQ mentioned this pull request Jul 18, 2024
Open
This was referenced Jul 20, 2024
Open
Open
@Carment14tham Carment14tham mentioned this pull request Jul 20, 2024
Open
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@flaviendelangle @DungTiger
[fields] Do not apply digit editing when pressing Space (mui#13510)
d2cb28b
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@flaviendelangle @thomasmoon
[fields] Do not apply digit editing when pressing Space (mui#13510)
bcc0da4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@arthurbalduini arthurbalduini Awaiting requested review from arthurbalduini

Assignees

@flaviendelangle flaviendelangle

Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! feature: Keyboard editing Related to the pickers keyboard edition needs cherry-pick The PR should be cherry-picked to master after merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DateTimePicker] Space sets subfield value to 00
3 participants
@flaviendelangle @mui-bot @LukasTy