[fields] Do not apply digit editing when pressing Space (mui#13510)

thomasmoon · Sep 6, 2024 · bcc0da4 · bcc0da4
1 parent 9e19704
commit bcc0da4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/x-date-pickers/src/TimeField/tests/editing.TimeField.test.tsx b/packages/x-date-pickers/src/TimeField/tests/editing.TimeField.test.tsx
@@ -621,6 +621,13 @@ describe('<TimeField /> - Editing', () => {
         keyStrokes: [{ value: 'p', expected: 'PM' }],
       });
     });
+
+    it('should not edit when pressing the Space key', () => {
+      testFieldChange({
+        format: adapter.formats.hours24h,
+        keyStrokes: [{ value: ' ', expected: 'hh' }],
+      });
+    });
   });
 
   describeAdapters(

diff --git a/packages/x-date-pickers/src/internals/hooks/useField/useField.utils.ts b/packages/x-date-pickers/src/internals/hooks/useField/useField.utils.ts
@@ -169,7 +169,8 @@ export const applyLocalizedDigits = (valueStr: string, localizedDigits: string[]
 
 export const isStringNumber = (valueStr: string, localizedDigits: string[]) => {
   const nonLocalizedValueStr = removeLocalizedDigits(valueStr, localizedDigits);
-  return !Number.isNaN(Number(nonLocalizedValueStr));
+  // `Number(' ')` returns `0` even if ' ' is not a valid number.
+  return nonLocalizedValueStr !== ' ' && !Number.isNaN(Number(nonLocalizedValueStr));
 };
 
 /**