Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DatePicker] Initial commit #3451

Merged
merged 351 commits into from
Mar 29, 2022
Merged

[DatePicker] Initial commit #3451

merged 351 commits into from
Mar 29, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Dec 17, 2021 •
edited
Loading

Closes #2398

Doc preview
Codesandbox pro example

Changes

For the view types, I removed the duplicates and only kept the type with the name of the view component, not the ones with the name of the pickers (clock not time, calendar not date, calendarOrClock not dateTime)

  • ClockView, TimePickerView, ClockPickerView
  • DatePickerView, CalendarPickerView
  • DateTimePickerView, CalendarOrClockPickerView

Removing ClockPickerStandalone and instead have ClockPicker handle the controlled / uncontrolled pattern just like in CalendarPicker

  • Add root slot for ClockPicker

  • Rename PickersCalendar into DayPicker

PRs ready to be picked:

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 20, 2021
@flaviendelangle flaviendelangle marked this pull request as draft December 21, 2021 08:30
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Dec 21, 2021
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@flaviendelangle flaviendelangle self-assigned this Dec 21, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 21, 2021
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 3, 2022
@github-actions
Copy link

github-actions bot commented Jan 3, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 3, 2022
@flaviendelangle flaviendelangle mentioned this pull request Jan 5, 2022
Closed
8 tasks
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 7, 2022
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jan 10, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jan 12, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 19, 2022
@mui-bot
Copy link

mui-bot commented Jan 19, 2022 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 240.1 477.5 316.3 328.26 85.624
Sort 100k rows ms 477.8 947.2 642 682.5 154.688
Select 100k rows ms 113 224.3 195 188.16 40.008
Deselect 100k rows ms 89.5 216.5 202.6 160.72 50.838

Generated by 🚫 dangerJS against 5e74568

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 24, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 24, 2022
@flaviendelangle flaviendelangle mentioned this pull request Jan 24, 2022
Merged
6 tasks
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jan 24, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 24, 2022
@flaviendelangle
Copy link
Member Author

@alexfauquette concerning the references to DataGridPro or x-data-grid-pro in the api page, I removed some hardcoded values and synced the ApiPage file with the core (I can't use it directly because we have the concept of slots which they do not document).

@flaviendelangle flaviendelangle added the component: pickers This is the name of the generic UI component, not the React module! label Mar 25, 2022
@alexfauquette
Copy link
Member

I finally found Why date-range-picker description was empty, it's a regexp problem

The current one /date-range-picker.*.json$/ is valid for files such as

  • 'docs/translations/api-docs/date-pickers/static-date-range-picker.json'
  • 'docs/translations/api-docs/date-pickers/mobile-date-range-picker.json',
  • 'docs/translations/api-docs/date-pickers/desktop-date-range-picker.json',
  • 'docs/translations/api-docs/date-pickers/date-range-picker-day-pt.json',
  • 'docs/translations/api-docs/date-pickers/date-range-picker-day-zh.json',
  • ...

The . needs to be escaped and the lang tag must be restrained to 2 letters to avoid accepting "date-range-picker-day"

A solution can be /\/date-range-picker(-[a-z]{2})?\.json$/

  • 'docs/translations/api-docs/date-pickers/date-range-picker.json',
  • './date-range-picker.json',
  • './date-range-picker-pt.json',
  • './date-range-picker-zh.json',
  • 'docs/translations/api-docs/date-pickers/date-range-picker-pt.json',
  • 'docs/translations/api-docs/date-pickers/date-range-picker-zh.json'

@flaviendelangle
Copy link
Member Author

A solution can be //date-range-picker(-[a-z]{2})?.json$/

Done

@flaviendelangle flaviendelangle merged commit 0b46ebc into mui:master Mar 29, 2022
@flaviendelangle flaviendelangle deleted the date-picker branch March 29, 2022 10:46
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@flaviendelangle @alexfauquette
[DatePicker] Initial commit (mui#3451)
1271022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp left review comments

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees

@flaviendelangle flaviendelangle

Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC] Migrate date pickers from the lab to MUI X
5 participants
@flaviendelangle @mui-bot @siriwatknp @alexfauquette @m4theushw