-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Prepare infra for pickers migration #3714
Conversation
These are the results for the performance tests:
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
@@ -38,6 +38,7 @@ module.exports = { | |||
'*.test.js', | |||
'*.test.ts', | |||
'*.test.tsx', | |||
'test/**', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? I ran yarn lint
in #3451 without it and test/utils/pickers-utils.tsx
failed. Looking at this file, it seems that we could import CreateRendererOptions
from @mui/monorepo/test/utils
maybe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't because there is no index.ts
file at @mui/monorepo/test/utils
so I can't import from there.
But I can add an eslint-disable-line
to move on and propose a modification on the core
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Extracted from #3451
Part of #3608
Part of #2398
Codesandbox example to show that the babel config modifications don't break the grid.
Sync
.browserlist
with the coreAllow to use the core bundling strategy by re-importing
scripts/build.js
,scripts/buildTypes.js
and copyingscripts/copy-files.js
(the current core file copy the license for each module, I will improve it later to only copy it if the package does not already have one)Add eslint rule to avoid import from a package inside itself
Copy eslint rule from the core for the custom
material-ui/mui-name-matches-component-name
Rename
yarn eslint
intoyarn lint
to follow the code naming and enable the cachingEdit the babel config to add
@babel/plugin-proposal-private-methods
and@babel/plugin-proposal-private-property-in-object
like in the core