Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Prepare infra for pickers migration #3714

Merged
merged 7 commits into from
Jan 31, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Jan 24, 2022

Extracted from #3451
Part of #3608
Part of #2398

Codesandbox example to show that the babel config modifications don't break the grid.

  • Sync .browserlist with the core

  • Allow to use the core bundling strategy by re-importing scripts/build.js, scripts/buildTypes.js and copying scripts/copy-files.js (the current core file copy the license for each module, I will improve it later to only copy it if the package does not already have one)

  • Add eslint rule to avoid import from a package inside itself

  • Copy eslint rule from the core for the custom material-ui/mui-name-matches-component-name

  • Rename yarn eslint into yarn lint to follow the code naming and enable the caching

  • Edit the babel config to add @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object like in the core

@flaviendelangle flaviendelangle self-assigned this Jan 24, 2022
@mui-bot
Copy link

mui-bot commented Jan 24, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 1,109.7 1,721.4 1,278.7 1,393.48 263.746
Sort 100k rows ms 665.3 1,211 1,211 976.42 208.975
Select 100k rows ms 180.4 202.6 185 190.6 9.106
Deselect 100k rows ms 98.6 146.5 143.9 123.7 18.759

Generated by 🚫 dangerJS against a335093

@flaviendelangle flaviendelangle marked this pull request as ready for review January 24, 2022 10:28
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 24, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 25, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 25, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 26, 2022
@@ -38,6 +38,7 @@ module.exports = {
'*.test.js',
'*.test.ts',
'*.test.tsx',
'test/**',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? I ran yarn lint in #3451 without it and test/utils/pickers-utils.tsx failed. Looking at this file, it seems that we could import CreateRendererOptions from @mui/monorepo/test/utils maybe.

Copy link
Member Author

@flaviendelangle flaviendelangle Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't because there is no index.ts file at @mui/monorepo/test/utils so I can't import from there.
But I can add an eslint-disable-line to move on and propose a modification on the core

scripts/copy-files.js Outdated Show resolved Hide resolved
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 27, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 28, 2022
@flaviendelangle flaviendelangle merged commit ce1aebf into mui:master Jan 31, 2022
@cherniavskii cherniavskii added the core Infrastructure work going on behind the scenes label Feb 3, 2022
@flaviendelangle flaviendelangle deleted the infra-pickers branch November 18, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants