Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] New page for the pickers migration from the lab #4327

Merged
merged 9 commits into from
Apr 4, 2022
Merged

[docs] New page for the pickers migration from the lab #4327

merged 9 commits into from
Apr 4, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Apr 1, 2022 •
edited
Loading

@siriwatknp rightfully pointed out that we were missing a dedicated migration page.

Doc preview

@flaviendelangle flaviendelangle added docs Improvements or additions to the documentation component: pickers This is the name of the generic UI component, not the React module! labels Apr 1, 2022
@flaviendelangle flaviendelangle self-assigned this Apr 1, 2022
@mui-bot
Copy link

mui-bot commented Apr 1, 2022 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 237.2 403.8 311.5 308.68 62.522
Sort 100k rows ms 446.4 941.2 780.6 745.24 162.055
Select 100k rows ms 85.2 206.8 197.7 159.98 43.665
Deselect 100k rows ms 97.3 206.1 184.1 164.3 37.931

Generated by 🚫 dangerJS against 9ae7c0e

@flaviendelangle flaviendelangle mentioned this pull request Apr 1, 2022
Merged
flaviendelangle and others added 2 commits April 1, 2022 12:30
@flaviendelangle @siriwatknp
Update docs/data/date-pickers/migration-lab/migration-lab.md
2820756 
Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com>
@flaviendelangle @siriwatknp
Update docs/data/date-pickers/migration-lab/migration-lab.md
b323e1a 
Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com>
alexfauquette
alexfauquette approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice instructions 👍

docs/data/date-pickers/migration-lab/migration-lab.md Outdated Show resolved Hide resolved
siriwatknp
siriwatknp approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great!

@flaviendelangle flaviendelangle merged commit 2962d6a into mui:master Apr 4, 2022
@flaviendelangle flaviendelangle deleted the pickers-lab-migration branch April 4, 2022 07:04
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@flaviendelangle @alexfauquette
[docs] New page for the pickers migration from the lab (mui#4327)
b35f523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

@siriwatknp siriwatknp siriwatknp approved these changes

@samuelsycamore samuelsycamore Awaiting requested review from samuelsycamore

Assignees

@flaviendelangle flaviendelangle

Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flaviendelangle @mui-bot @siriwatknp @alexfauquette