Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v5.8.0 #4328

Merged
merged 10 commits into from
Apr 4, 2022
Merged

v5.8.0 #4328

merged 10 commits into from
Apr 4, 2022

Conversation

alexfauquette
Copy link
Member

Notes

  • I kept the title of the release note "5.8.0" even if now it does not make that much sense because we have two packages in a single release file

  • It's not visible in the git diff of this PR, but package.json files of the two date-picker packages are set with "version": "5.0.0-alpha.0".

@mui-bot
Copy link

mui-bot commented Apr 1, 2022 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 249.5 459.5 391.4 352.92 79.562
Sort 100k rows ms 480.1 1,062.5 765.5 807.34 192.888
Select 100k rows ms 114.9 283.7 220.8 200.28 64.302
Deselect 100k rows ms 103.2 209.6 158.5 156.38 39.645

Generated by 🚫 dangerJS against c0a6f4a

flaviendelangle
flaviendelangle reviewed Apr 1, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@flaviendelangle
Copy link
Member

For the title of the release PR, I am also in favor of keeping it release v5.X.X with the main version number, except if we do a partial release with just the pickers at some point.

flaviendelangle
flaviendelangle reviewed Apr 1, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
@@ -22,6 +22,22 @@ We'd like to offer a big thanks to the 7 contributors who made this release poss
- 📝 Add `onProcessRowUpdateError` prop to simplify error management in edit mode (#4267) @m4theushw
- ✨ Add generic typing to `GridColDef` and derived interfaces (#4064) @flaviendelangle

This allows to strongly type all the objects related to the row and the cell values.
Here is an example, you can can find out more in the description of #4064.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we should link to the description of a PR
Maybe for now it's the best solution, but we can create an issue to do a "TypeScript" data grid doc page and change the CHANGELOG to link to this new page when available.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done -> #4330

@m4theushw m4theushw added the release We are shipping :D label Apr 1, 2022
flaviendelangle
flaviendelangle reviewed Apr 1, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@alexfauquette alexfauquette mentioned this pull request Apr 1, 2022
Open
1 task
@alexfauquette @flaviendelangle
Apply suggestions from code review
7f5a902 
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
m4theushw
m4theushw reviewed Apr 1, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated

- ⌚️ Move date and time picker components from the lab (#3451) @flaviendelangle

date-picker components has been added to the MUI-X repo.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
date-picker components has been added to the MUI-X repo.
date-picker components have been added to the MUI X repo.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@m4theushw m4theushw changed the title release v5.8.0 v5.8.0 Apr 1, 2022
DanailH
DanailH reviewed Apr 1, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
joserodolfofreitas
joserodolfofreitas approved these changes Apr 1, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@alexfauquette @m4theushw @DanailH
Apply suggestions from code review
56cf71d 
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Co-authored-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
flaviendelangle
flaviendelangle reviewed Apr 4, 2022
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add this one #4327

And need to merge this one before release #4298

@alexfauquette alexfauquette merged commit 7f55c6e into mui:master Apr 4, 2022
@alexfauquette alexfauquette deleted the release-v5.8.0 branch April 4, 2022 14:28
@oliviertassinari oliviertassinari mentioned this pull request Apr 12, 2022
Merged
oliviertassinari
oliviertassinari reviewed Jul 12, 2022
View reviewed changes
scripts/README.md
@@ -27,6 +27,7 @@ The following steps must be proposed as a pull request.
- [ ] Clean the generated changelog, to match the format of [https://github.com/mui/mui-x/releases](https://github.com/mui/mui-x/releases).
- [ ] Update the root `package.json`'s version
- [ ] Update the versions of the other `package.json` files and of the dependencies with `yarn release:version`.
- [ ] Fix manually the package version in `x-date-picker/package.json` and `x-date-picker-pro/package.json`.
Copy link
Member

@oliviertassinari oliviertassinari Jul 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that in Material UI we had to set the version to independent as we had too many npm packages in the alpha release state. https://github.com/mui/material-ui/blob/88ad7d4e623183b8e20702e7961ef9c8de330dc7/lerna.json#L4.

If the date picker becomes stable soon enough and we don't have new unstable npm packages, maybe we can stick to the current configuration of MUI X. Hopefully, in Material UI, follow the same direction as well.

mui-x/lerna.json

Lines 1 to 4 in 4ba02b8

{
"npmClient": "yarn",
"useWorkspaces": true,
"version": "5.13.0"

alexfauquette added a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@alexfauquette @flaviendelangle
@m4theushw @DanailH
v5.8.0 (mui#4328)
10472c0 
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Co-authored-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4theushw m4theushw m4theushw left review comments

@DanailH DanailH DanailH left review comments

@oliviertassinari oliviertassinari oliviertassinari left review comments

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@joserodolfofreitas joserodolfofreitas joserodolfofreitas approved these changes

@samuelsycamore samuelsycamore Awaiting requested review from samuelsycamore

Assignees
No one assigned
Labels
release We are shipping :D
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alexfauquette @mui-bot @flaviendelangle @joserodolfofreitas @oliviertassinari @DanailH @m4theushw