[core] Remove Storybook #6040
[core] Remove Storybook #6040
Conversation
flaviendelangle
requested review from
oliviertassinari,
DanailH and
m4theushw
|
These are the results for the performance tests:
|
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
| @@ -24,6 +24,10 @@ module.exports = { | |||
| new webpack.DefinePlugin({ | |||
| DISABLE_CHANCE_RANDOM: JSON.stringify(true), | |||
| }), | |||
| new webpack.ProvidePlugin({ | |||
There was a problem hiding this comment.
Copied from the core
https://github.com/mui/material-ui/blob/c8feb29320a22cc4461fb5ef5f4f7de7bd96a59b/test/regressions/webpack.config.js#L26
I think the Storybook was injecting a default config somehow.
| rows: GridBasicRowModel[]; | ||
| } | ||
|
|
||
| export const getBasicGridData = (rowLength: number, colLength: number): GridBasicData => { |
There was a problem hiding this comment.
Nice, I guess this was part of the storybook package. I wanter if we can remove it altogether and just use either the Commodity or Employee data sets. If there are no assertions in the tests related to the value of the cells then replacing the data set should be more or less easy, what do you think?
There was a problem hiding this comment.
Yep, it's the old useData and getData.
For the tests, it can be useful to have those dummy data tests without any intelligence behind them.
For instance in the pagination, it makes very clear what you are testing.
I would personally be in favor of an even dumber data set.
Something like:
{ id: 0, name: `name-0` },
{ id: 1, name: `name-1' },
...
And to use it everywhere we have some "Nike" / "Puma" dataset.
To reduce as much as possible the complexity of understanding the dataset and focusing on the actual behavior we are testing.
| </div> | ||
| ); | ||
| }; | ||
| export const MultilineCustomCellContentSnap = () => { |
There was a problem hiding this comment.
Since the Argos CI step is broken, we don't have visibility on the scale of this, but here is one visual test that is gone. Will we miss these visual regression tests?
There was a problem hiding this comment.
Here are all the stories with the Snap suffix
If the team wants to migrate some to a hidden doc example I can do it
I personally don't see any good candidate.
There was a problem hiding this comment.
I personally don't see any good candidate.
Then I think that we are good
to a hidden doc example
In the main repo, we store them here https://github.com/mui/material-ui/tree/master/test/regressions/fixtures (outside of the docs)
There was a problem hiding this comment.
Oh I think we had pickers fixtures that I did not migrate 😄
I'll have a look to maybe bring back this logic later
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
This reverts commit e15560c.
We discussed the Storybook yesterday: https://mui-org.notion.site/xGrid-Weekly-meeting-2022-09-05-931b28fff95b43d4905f328a884076b1.
It has received almost no new story in a year and is therefore totally outdated.
Right now, it is only an overhead that we have to maintain.
useDataandgetDatautilities that are being used in tests from the storybook to@mui/x-data-grid-generatorstorybookinternal package