[core] Simplify testing architecture #6043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the results for the performance tests:
|
flaviendelangle
commented
Sep 6, 2022
| @@ -1,3 +1,4 @@ | |||
| require('@babel/register')({ | |||
| extensions: ['.js', '.ts', '.tsx'], | |||
| ignore: [/node_modules\/(?!@mui\/monorepo)/], | |||
There was a problem hiding this comment.
We had two babel files with almost the same config.
I removed the one in the old setup.js file and used this one everywhere.
flaviendelangle
commented
Sep 6, 2022
|
|
||
| // The JSDOM implementation is too slow | ||
| // https://github.com/jsdom/jsdom/issues/3234 | ||
| window.getComputedStyle = function getComputedStyleMock() { |
There was a problem hiding this comment.
Copied from the old createDOM.js file
Unify RFC template using core version
flaviendelangle
requested review from
oliviertassinari,
m4theushw and
cherniavskii
github-actions
bot
added
the
PR: out-of-date
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
PR: out-of-date
packages/grid/x-data-grid-pro/src/tests/printExport.DataGrid.test.tsx
Outdated
Show resolved
Hide resolved
m4theushw
reviewed
Sep 23, 2022
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
cherniavskii
approved these changes
Sep 29, 2022
|
Nice cleanup :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
@mui/monoreposetupJSDOMfile to avoid duplicating code (equivalent of our currentsetup.jsfile which is badly named by the way).This has a side effect. The core adds the
url: 'http://localhost'property to its JSDOM instance, which breaks our print tests becauseprintWindow.contentDocument.bodyis now null (don't know why).If we don't find a fix, I can either copy / paste the
setupJSDOMfile to remove theurlproperty or make it optional on the core, or skip the printing test when using JSDOM (what I currently did).Use the same file naming strategy as in the core
Set the license key before each test to prepare [license] Add new license status 'Out of scope' #5260 (comment)
Avoid mocha hook duplication (for example we had a
sinon.restoreon bothsetup.jsfortest:unitand onkarma.test.jsfortest.karma.