-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Stop using the WrapperVariantContext
in MonthCalendar
and YearCalendar
#7382
Conversation
5e6d0e8
to
c970c83
Compare
These are the results for the performance tests:
|
c970c83
to
fadecc6
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
be72d9d
to
bd374b8
Compare
bd374b8
to
06fed48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great ❤️
Leaving a few nitpick comments.
packages/x-date-pickers/src/DesktopNextDatePicker/DesktopNextDatePicker.types.ts
Show resolved
Hide resolved
4e731fa
to
e50824d
Compare
packages/x-date-pickers/src/DesktopNextDatePicker/DesktopNextDatePicker.tsx
Outdated
Show resolved
Hide resolved
@LukasTy I added a migration guide |
b6da3a7
to
849cbc9
Compare
8ffd7a8
to
68edf42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🚀
This had a lot of small moving parts. 🙈
I added a migration guide
I think almost nobody uses this so maybe we can even skip the variable export and hardcode the media query on thediff
.
Indeed, probably 0.1% would have depended on those classes, but better to account for those than to handle issues later down the line. 👍
Part of #7372
Changelog
Breaking changes
The
modeMobile
andmodeDesktop
classes have been removed from thePickersMonth
andPickersYear
internal components.If you were using those classes on responsive components,
you can import
DEFAULT_DESKTOP_MODE_MEDIA_QUERY
from@mui/x-date-pickers
or@mui/x-date-pickers-pro
(or use your custom media query if any):Works exactly the same way for
PickersMonth