Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Stop using the WrapperVariantContext in MonthCalendar and YearCalendar #7382

Merged
merged 13 commits into from
Jan 12, 2023
Merged

[pickers] Stop using the WrapperVariantContext in MonthCalendar and YearCalendar #7382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fadecc6
[pickers] Stop using the wrapperVariant context in MonthCalendar and …
flaviendelangle Jan 3, 2023
8e2b152
Fix
flaviendelangle Jan 4, 2023
9ae50f5
Fix test
flaviendelangle Jan 4, 2023
840ef31
Merge branch 'next' into items-per-row
flaviendelangle Jan 4, 2023
53001de
Merge
flaviendelangle Jan 9, 2023
5f7bd95
Fix
flaviendelangle Jan 10, 2023
06fed48
Merge
flaviendelangle Jan 10, 2023
481d0d7
Merge branch 'next' into items-per-row
flaviendelangle Jan 11, 2023
e50824d
Code review: Lukas
flaviendelangle Jan 11, 2023
4fb201b
Merge branch 'next' into items-per-row
flaviendelangle Jan 12, 2023
01aba06
Code review: Lukas
flaviendelangle Jan 12, 2023
849cbc9
Add migration guide
flaviendelangle Jan 12, 2023
68edf42
Code review: Lukas
flaviendelangle Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions docs/data/migration/migration-pickers-v5/migration-pickers-v5.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,41 @@ If you want to keep the previous behavior, you just have to set the `ampm` prop
+ <TimeClock ampm={false} />
```

### Stop using the responsive classes on `PickersMonth` and `PickersYear`

The `modeMobile` and `modeDesktop` classes have been removed from the `PickersMonth` and `PickersYear` internal components.

If you were using those classes on responsive components,
you can import `DEFAULT_DESKTOP_MODE_MEDIA_QUERY` from `@mui/x-date-pickers` or `@mui/x-date-pickers-pro` (or use your custom media query if any):

```diff
<GlobalStyles
styles={{
- [`.${pickersYearClasses.modeDesktop}`]: {
- backgroundColor: 'red'
- }
+ [DEFAULT_DESKTOP_MODE_MEDIA_QUERY]: {
+ [`.${pickersYearClasses.root}`]: {
+ backgroundColor: 'red'
+ }
+ }

- [`.${pickersYearClasses.modeMobile}`]: {
- backgroundColor: 'red'
- }
+ [DEFAULT_DESKTOP_MODE_MEDIA_QUERY.replace('@media', '@media not')]: {
+ [`.${pickersYearClasses.root}`]: {
+ backgroundColor: 'red'
+ }
+ }
}}
/>
```

:::info
Works exactly the same way for `PickersMonth`
:::

## Localization

### ✅ Rename localization props
Expand Down
8 changes: 8 additions & 0 deletions docs/pages/x/api/date-pickers/date-calendar.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@
"loading": { "type": { "name": "bool" } },
"maxDate": { "type": { "name": "any" } },
"minDate": { "type": { "name": "any" } },
"monthsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
},
"onChange": { "type": { "name": "func" } },
"onFocusedViewChange": { "type": { "name": "func" } },
"onMonthChange": { "type": { "name": "func" } },
Expand Down Expand Up @@ -66,6 +70,10 @@
"name": "arrayOf",
"description": "Array&lt;'day'<br>&#124;&nbsp;'month'<br>&#124;&nbsp;'year'&gt;"
}
},
"yearsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
}
},
"slots": {
Expand Down
8 changes: 8 additions & 0 deletions docs/pages/x/api/date-pickers/date-picker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@
"mask": { "type": { "name": "string" } },
"maxDate": { "type": { "name": "any" } },
"minDate": { "type": { "name": "any" } },
"monthsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
},
"onAccept": { "type": { "name": "func" } },
"onClose": { "type": { "name": "func" } },
"onError": { "type": { "name": "func" } },
Expand Down Expand Up @@ -91,6 +95,10 @@
"description": "Array&lt;'day'<br>&#124;&nbsp;'month'<br>&#124;&nbsp;'year'&gt;"
},
"default": "['year', 'day']"
},
"yearsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "4 on desktop, 3 on mobile"
}
},
"slots": {
Expand Down
8 changes: 8 additions & 0 deletions docs/pages/x/api/date-pickers/date-time-picker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@
"minDateTime": { "type": { "name": "any" } },
"minTime": { "type": { "name": "any" } },
"minutesStep": { "type": { "name": "number" }, "default": "1" },
"monthsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
},
"onAccept": { "type": { "name": "func" } },
"onClose": { "type": { "name": "func" } },
"onError": { "type": { "name": "func" } },
Expand Down Expand Up @@ -107,6 +111,10 @@
"description": "Array&lt;'day'<br>&#124;&nbsp;'hours'<br>&#124;&nbsp;'minutes'<br>&#124;&nbsp;'month'<br>&#124;&nbsp;'seconds'<br>&#124;&nbsp;'year'&gt;"
},
"default": "['year', 'day', 'hours', 'minutes']"
},
"yearsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "4 on desktop, 3 on mobile"
}
},
"slots": {
Expand Down
8 changes: 8 additions & 0 deletions docs/pages/x/api/date-pickers/desktop-date-picker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@
"mask": { "type": { "name": "string" } },
"maxDate": { "type": { "name": "any" } },
"minDate": { "type": { "name": "any" } },
"monthsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
},
"onAccept": { "type": { "name": "func" } },
"onClose": { "type": { "name": "func" } },
"onError": { "type": { "name": "func" } },
Expand Down Expand Up @@ -87,6 +91,10 @@
"description": "Array&lt;'day'<br>&#124;&nbsp;'month'<br>&#124;&nbsp;'year'&gt;"
},
"default": "['year', 'day']"
},
"yearsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "4"
}
},
"slots": {
Expand Down
8 changes: 8 additions & 0 deletions docs/pages/x/api/date-pickers/desktop-date-time-picker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@
"minDateTime": { "type": { "name": "any" } },
"minTime": { "type": { "name": "any" } },
"minutesStep": { "type": { "name": "number" }, "default": "1" },
"monthsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
},
"onAccept": { "type": { "name": "func" } },
"onClose": { "type": { "name": "func" } },
"onError": { "type": { "name": "func" } },
Expand Down Expand Up @@ -103,6 +107,10 @@
"description": "Array&lt;'day'<br>&#124;&nbsp;'hours'<br>&#124;&nbsp;'minutes'<br>&#124;&nbsp;'month'<br>&#124;&nbsp;'seconds'<br>&#124;&nbsp;'year'&gt;"
},
"default": "['year', 'day', 'hours', 'minutes']"
},
"yearsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
}
},
"slots": {
Expand Down
8 changes: 8 additions & 0 deletions docs/pages/x/api/date-pickers/desktop-next-date-picker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@
"localeText": { "type": { "name": "object" } },
"maxDate": { "type": { "name": "any" } },
"minDate": { "type": { "name": "any" } },
"monthsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
},
"onAccept": { "type": { "name": "func" } },
"onChange": { "type": { "name": "func" } },
"onClose": { "type": { "name": "func" } },
Expand Down Expand Up @@ -92,6 +96,10 @@
"name": "arrayOf",
"description": "Array&lt;'day'<br>&#124;&nbsp;'month'<br>&#124;&nbsp;'year'&gt;"
}
},
"yearsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "4"
}
},
"slots": {
Expand Down
8 changes: 8 additions & 0 deletions docs/pages/x/api/date-pickers/desktop-next-date-time-picker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@
"minDateTime": { "type": { "name": "any" } },
"minTime": { "type": { "name": "any" } },
"minutesStep": { "type": { "name": "number" }, "default": "1" },
"monthsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
},
"onAccept": { "type": { "name": "func" } },
"onChange": { "type": { "name": "func" } },
"onClose": { "type": { "name": "func" } },
Expand Down Expand Up @@ -109,6 +113,10 @@
"name": "arrayOf",
"description": "Array&lt;'day'<br>&#124;&nbsp;'hours'<br>&#124;&nbsp;'minutes'<br>&#124;&nbsp;'month'<br>&#124;&nbsp;'seconds'<br>&#124;&nbsp;'year'&gt;"
}
},
"yearsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "4"
}
},
"slots": {
Expand Down
8 changes: 8 additions & 0 deletions docs/pages/x/api/date-pickers/mobile-date-picker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@
"mask": { "type": { "name": "string" } },
"maxDate": { "type": { "name": "any" } },
"minDate": { "type": { "name": "any" } },
"monthsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
},
"onAccept": { "type": { "name": "func" } },
"onClose": { "type": { "name": "func" } },
"onError": { "type": { "name": "func" } },
Expand Down Expand Up @@ -87,6 +91,10 @@
"description": "Array&lt;'day'<br>&#124;&nbsp;'month'<br>&#124;&nbsp;'year'&gt;"
},
"default": "['year', 'day']"
},
"yearsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
}
},
"slots": {
Expand Down
8 changes: 8 additions & 0 deletions docs/pages/x/api/date-pickers/mobile-date-time-picker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@
"minDateTime": { "type": { "name": "any" } },
"minTime": { "type": { "name": "any" } },
"minutesStep": { "type": { "name": "number" }, "default": "1" },
"monthsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
},
"onAccept": { "type": { "name": "func" } },
"onClose": { "type": { "name": "func" } },
"onError": { "type": { "name": "func" } },
Expand Down Expand Up @@ -103,6 +107,10 @@
"description": "Array&lt;'day'<br>&#124;&nbsp;'hours'<br>&#124;&nbsp;'minutes'<br>&#124;&nbsp;'month'<br>&#124;&nbsp;'seconds'<br>&#124;&nbsp;'year'&gt;"
},
"default": "['year', 'day', 'hours', 'minutes']"
},
"yearsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
}
},
"slots": {
Expand Down
8 changes: 8 additions & 0 deletions docs/pages/x/api/date-pickers/mobile-next-date-picker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@
"localeText": { "type": { "name": "object" } },
"maxDate": { "type": { "name": "any" } },
"minDate": { "type": { "name": "any" } },
"monthsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
},
"onAccept": { "type": { "name": "func" } },
"onChange": { "type": { "name": "func" } },
"onClose": { "type": { "name": "func" } },
Expand Down Expand Up @@ -92,6 +96,10 @@
"name": "arrayOf",
"description": "Array&lt;'day'<br>&#124;&nbsp;'month'<br>&#124;&nbsp;'year'&gt;"
}
},
"yearsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
}
},
"slots": {
Expand Down
8 changes: 8 additions & 0 deletions docs/pages/x/api/date-pickers/mobile-next-date-time-picker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@
"minDateTime": { "type": { "name": "any" } },
"minTime": { "type": { "name": "any" } },
"minutesStep": { "type": { "name": "number" }, "default": "1" },
"monthsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
},
"onAccept": { "type": { "name": "func" } },
"onChange": { "type": { "name": "func" } },
"onClose": { "type": { "name": "func" } },
Expand Down Expand Up @@ -109,6 +113,10 @@
"name": "arrayOf",
"description": "Array&lt;'day'<br>&#124;&nbsp;'hours'<br>&#124;&nbsp;'minutes'<br>&#124;&nbsp;'month'<br>&#124;&nbsp;'seconds'<br>&#124;&nbsp;'year'&gt;"
}
},
"yearsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
}
},
"slots": {
Expand Down
4 changes: 4 additions & 0 deletions docs/pages/x/api/date-pickers/month-calendar.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@
"disablePast": { "type": { "name": "bool" } },
"maxDate": { "type": { "name": "any" } },
"minDate": { "type": { "name": "any" } },
"monthsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
},
"onChange": { "type": { "name": "func" } },
"readOnly": { "type": { "name": "bool" } },
"shouldDisableMonth": { "type": { "name": "func" } },
Expand Down
8 changes: 8 additions & 0 deletions docs/pages/x/api/date-pickers/next-date-picker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@
"localeText": { "type": { "name": "object" } },
"maxDate": { "type": { "name": "any" } },
"minDate": { "type": { "name": "any" } },
"monthsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
},
"onAccept": { "type": { "name": "func" } },
"onChange": { "type": { "name": "func" } },
"onClose": { "type": { "name": "func" } },
Expand Down Expand Up @@ -96,6 +100,10 @@
"name": "arrayOf",
"description": "Array&lt;'day'<br>&#124;&nbsp;'month'<br>&#124;&nbsp;'year'&gt;"
}
},
"yearsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "4 on desktop, 3 on mobile"
}
},
"slots": {
Expand Down
8 changes: 8 additions & 0 deletions docs/pages/x/api/date-pickers/next-date-time-picker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@
"minDateTime": { "type": { "name": "any" } },
"minTime": { "type": { "name": "any" } },
"minutesStep": { "type": { "name": "number" }, "default": "1" },
"monthsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
},
"onAccept": { "type": { "name": "func" } },
"onChange": { "type": { "name": "func" } },
"onClose": { "type": { "name": "func" } },
Expand Down Expand Up @@ -113,6 +117,10 @@
"name": "arrayOf",
"description": "Array&lt;'day'<br>&#124;&nbsp;'hours'<br>&#124;&nbsp;'minutes'<br>&#124;&nbsp;'month'<br>&#124;&nbsp;'seconds'<br>&#124;&nbsp;'year'&gt;"
}
},
"yearsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "4 on desktop, 3 on mobile"
}
},
"slots": {
Expand Down
8 changes: 8 additions & 0 deletions docs/pages/x/api/date-pickers/static-date-picker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@
"mask": { "type": { "name": "string" } },
"maxDate": { "type": { "name": "any" } },
"minDate": { "type": { "name": "any" } },
"monthsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
},
"onAccept": { "type": { "name": "func" } },
"onError": { "type": { "name": "func" } },
"onMonthChange": { "type": { "name": "func" } },
Expand Down Expand Up @@ -88,6 +92,10 @@
"description": "Array&lt;'day'<br>&#124;&nbsp;'month'<br>&#124;&nbsp;'year'&gt;"
},
"default": "['year', 'day']"
},
"yearsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
}
},
"slots": {
Expand Down
8 changes: 8 additions & 0 deletions docs/pages/x/api/date-pickers/static-date-time-picker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@
"minDateTime": { "type": { "name": "any" } },
"minTime": { "type": { "name": "any" } },
"minutesStep": { "type": { "name": "number" }, "default": "1" },
"monthsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
},
"onAccept": { "type": { "name": "func" } },
"onError": { "type": { "name": "func" } },
"onMonthChange": { "type": { "name": "func" } },
Expand Down Expand Up @@ -104,6 +108,10 @@
"description": "Array&lt;'day'<br>&#124;&nbsp;'hours'<br>&#124;&nbsp;'minutes'<br>&#124;&nbsp;'month'<br>&#124;&nbsp;'seconds'<br>&#124;&nbsp;'year'&gt;"
},
"default": "['year', 'day', 'hours', 'minutes']"
},
"yearsPerRow": {
"type": { "name": "enum", "description": "3<br>&#124;&nbsp;4" },
"default": "3"
}
},
"slots": {
Expand Down
Loading