[nextjs] Move the import startsWith next check at end #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This fixes the resolve error happening in nextjs for it's path based module imports. * Also adds check for `next/link` * Ignore null value during css object processing
Janpot
reviewed
Sep 11, 2024
siriwatknp
reviewed
Sep 11, 2024
Comment on lines
158
to
161
| if (!value) { | ||
| // ignore null value | ||
| return; | ||
| } |
There was a problem hiding this comment.
Can you review this instead #229
brijeshb42
force-pushed
the
fix/null-value
branch
from
dabcee4 to
bf715be
Compare
Janpot
approved these changes
Sep 11, 2024
| return require.resolve(what); | ||
| } | ||
| if (what === 'next/image') { | ||
| if (what === 'next/image' || what === 'next/link') { |
There was a problem hiding this comment.
If what==='next/link' we still import next-image? @brijeshb42
There was a problem hiding this comment.
Both just point to a dummy module for wyw evaluation to work.
There was a problem hiding this comment.
next/link just provides a default export which is already there in the next-image file.
There was a problem hiding this comment.
We could just rename the next-image file to next-module-stub or similar to remove the confusion.
It's on our side and not user facing.
brijeshb42
pushed a commit
to brijeshb42/pigment-css
that referenced
this pull request
Sep 13, 2024
brijeshb42
added a commit
that referenced
this pull request
Sep 13, 2024
This was referenced Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next/linkFixes #204