Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nextjs] Fix react import check bug introduced in #228 #236

Merged
merged 1 commit into from
Sep 13, 2024
Merged

[nextjs] Fix react import check bug introduced in #228 #236

merged 1 commit into from
Sep 13, 2024

Conversation

brijeshb42
Copy link
Contributor

Adds a check for imports starting with react/ as well besides react which fixes imports like react/jsx-runtime.

@brijeshb42 brijeshb42 added bug 🐛 Something doesn't work nextjs labels Sep 13, 2024
@brijeshb42 brijeshb42 requested a review from a team September 13, 2024 07:33
@siriwatknp
Copy link
Member

Does this need for vite too?

@brijeshb42
Copy link
Contributor Author

No. It's specific to nextjs app router.

@brijeshb42 brijeshb42 merged commit 1e38917 into mui:master Sep 13, 2024
14 checks passed
@brijeshb42 brijeshb42 deleted the fix/nextjs-react branch September 13, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work nextjs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brijeshb42 @siriwatknp