Allow recreating data grid columns from existing data #914
Conversation
|
Your Render PR Server URL is https://toolpad-pr-914.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cccbc8un6mprmh1icu80. |
oliviertassinari
requested a deployment
to
recreate-columns - toolpad-db PR #914
Render
Abandoned
| @@ -176,6 +188,13 @@ function GridColumnsPropEditor({ | |||
| <React.Fragment> | |||
| <DialogTitle>Edit columns</DialogTitle> | |||
| <DialogContent> | |||
| <IconButton | |||
| aria-label="Recreate columns" | |||
There was a problem hiding this comment.
We should probably add a tooltip instead.
@prakhargupta1 @gerdadesign nominating this component as well for a redesign. Perhaps we could even put this inline in the inspector, instead of in a dialog?
There was a problem hiding this comment.
good idea, i'll add
There was a problem hiding this comment.
I've added tooltips to the "Recreate columns" and the "Add column" buttons
| </IconButton> | ||
| <Tooltip title="Recreate columns"> | ||
| <IconButton | ||
| aria-label="Recreate columns" |
There was a problem hiding this comment.
cool i didn't know, i've removed the unnecessary props + added a span so that the tooltip shows when the "recreate columns" button is disabled (as recommended by the MUI console warnings)
| > | ||
| <RefreshIcon /> | ||
| </IconButton> | ||
| <span> |
There was a problem hiding this comment.
this prevents it from passing the aria label to the button, right?
There was a problem hiding this comment.
it's passed to the span, actually that might not be ok good point
There was a problem hiding this comment.
i added describeChild to the tooltip and aria-label in the button, seems like the right way to do it
Allow for recreating columns in Data Grid elements, from existing data.
Replaces all columns with the inferred columns when the button is pressed.
Screen.Recording.2022-09-07.at.16.14.37.mov