Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow recreating data grid columns from existing data #914

Merged
merged 10 commits into from
Sep 8, 2022
Merged

Allow recreating data grid columns from existing data #914

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
41bf244
Allow recreating data grid columns from existing data
apedroferreira Sep 7, 2022
2bc1fcf
Merge remote-tracking branch 'origin/master' into recreate-columns
apedroferreira Sep 7, 2022
22517d7
Add tooltips
apedroferreira Sep 7, 2022
4ae884b
Use tooltip accessbility props
apedroferreira Sep 7, 2022
07b868d
Run yarn upgrade
apedroferreira Sep 7, 2022
67a69d1
Merge remote-tracking branch 'origin/master' into yarn-upgrade-7-sept-22
apedroferreira Sep 7, 2022
0638e65
Merge remote-tracking branch 'origin/yarn-upgrade-7-sept-22' into rec…
apedroferreira Sep 7, 2022
3ab0cc8
Remove unnecessary props and add span
apedroferreira Sep 7, 2022
d85bc76
Merge remote-tracking branch 'origin/master' into recreate-columns
apedroferreira Sep 7, 2022
f814200
move accessibility prop to button
apedroferreira Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions packages/toolpad-app/src/toolpad/propertyControls/GridColumns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,16 +190,14 @@ function GridColumnsPropEditor({
<DialogTitle>Edit columns</DialogTitle>
<DialogContent>
<Tooltip title="Recreate columns">
<IconButton
aria-label="Recreate columns"
onClick={handleRecreateColumns}
disabled={!hasColumnSuggestions}
>
<RefreshIcon />
</IconButton>
<span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this prevents it from passing the aria label to the button, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's passed to the span, actually that might not be ok good point

Copy link
Member Author

@apedroferreira apedroferreira Sep 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added describeChild to the tooltip and aria-label in the button, seems like the right way to do it

<IconButton onClick={handleRecreateColumns} disabled={!hasColumnSuggestions}>
<RefreshIcon />
</IconButton>
</span>
</Tooltip>
<Tooltip title="Add column">
<IconButton aria-label="Add column" onClick={handleMenuClick} disabled={disabled}>
<IconButton onClick={handleMenuClick} disabled={disabled}>
<AddIcon />
</IconButton>
</Tooltip>
Expand Down
Loading