Refactor construction API

server/services/common.go

@@ -38,7 +38,16 @@ func fromObjectsMap(obj objectsMap, value any) error {
 }
 
 func isZeroAmount(amount string) bool {
-	return amount == "" || amount == "0" || amount == "-0"
+	if amount == "" {
+		return true
+	}
+
+	value, ok := big.NewInt(0).SetString(amount, 10)
+	if ok {
+		return value.Sign() == 0
+	}
+
+	return false
 }
 
 func getMagnitudeOfAmount(amount string) string {

server/services/common_test.go

@@ -37,6 +37,7 @@ func Test_IsZeroAmount(t *testing.T) {
 	require.True(t, isZeroAmount(""))
 	require.True(t, isZeroAmount("0"))
 	require.True(t, isZeroAmount("-0"))
+	require.True(t, isZeroAmount("00"))
 	require.False(t, isZeroAmount("1"))
 	require.False(t, isZeroAmount("-1"))
 }

server/services/constructionMetadata.go

@@ -3,6 +3,7 @@ package services
 import (
 	"encoding/json"
 	"errors"
+	"fmt"
 
 	"github.com/ElrondNetwork/elrond-proxy-go/data"
 )
@@ -50,16 +51,17 @@ func (metadata *constructionMetadata) toTransaction() (*data.Transaction, error)
 		return nil, err
 	}
 
-	tx := &data.Transaction{}
-	tx.Sender = metadata.Sender
-	tx.Receiver = metadata.Receiver
-	tx.Nonce = metadata.Nonce
-	tx.Value = metadata.Amount
-	tx.GasLimit = metadata.GasLimit
-	tx.GasPrice = metadata.GasPrice
-	tx.Data = metadata.Data
-	tx.ChainID = metadata.ChainID
-	tx.Version = uint32(metadata.Version)
+	tx := &data.Transaction{
+		Sender:   metadata.Sender,
+		Receiver: metadata.Receiver,
+		Nonce:    metadata.Nonce,
+		Value:    metadata.Amount,
+		GasLimit: metadata.GasLimit,
+		GasPrice: metadata.GasPrice,
+		Data:     metadata.Data,
+		ChainID:  metadata.ChainID,
+		Version:  uint32(metadata.Version),
+	}
 
 	return tx, nil
 }
@@ -78,7 +80,7 @@ func (metadata *constructionMetadata) validate() error {
 		return errors.New("missing metadata: 'gasPrice'")
 	}
 	if metadata.Version != 1 {
-		return errors.New("bad metadata: unexpected 'version'")
+		return fmt.Errorf("bad metadata: unexpected 'version' %v", metadata.Version)
 	}
 	if len(metadata.ChainID) == 0 {
 		return errors.New("missing metadata: 'chainID'")

server/services/constructionMetadata_test.go

@@ -53,15 +53,15 @@ func TestConstructionMetadata_Validate(t *testing.T) {
 		Receiver: "bob",
 		GasLimit: 50000,
 		GasPrice: 1000000000,
-	}).validate(), "bad metadata: unexpected 'version'")
+	}).validate(), "bad metadata: unexpected 'version' 0")
 
 	require.ErrorContains(t, (&constructionMetadata{
 		Sender:   "alice",
 		Receiver: "bob",
 		GasLimit: 50000,
 		GasPrice: 1000000000,
 		Version:  42,
-	}).validate(), "bad metadata: unexpected 'version'")
+	}).validate(), "bad metadata: unexpected 'version' 42")
 
 	require.ErrorContains(t, (&constructionMetadata{
 		Sender:   "alice",

server/services/constructionService.go

@@ -140,17 +140,18 @@ func (service *constructionService) ConstructionMetadata(
 		return nil, errTyped
 	}
 
-	metadata := &constructionMetadata{}
-	metadata.Nonce = account.Account.Nonce
-	metadata.Sender = requestOptions.Sender
-	metadata.Receiver = requestOptions.Receiver
-	metadata.Amount = requestOptions.Amount
-	metadata.CurrencySymbol = requestOptions.CurrencySymbol
-	metadata.GasLimit = gasLimit
-	metadata.GasPrice = gasPrice
-	metadata.Data = computedData
-	metadata.ChainID = service.provider.GetNetworkConfig().NetworkID
-	metadata.Version = transactionVersion
+	metadata := &constructionMetadata{
+		Nonce:          account.Account.Nonce,
+		Sender:         requestOptions.Sender,
+		Receiver:       requestOptions.Receiver,
+		Amount:         requestOptions.Amount,
+		CurrencySymbol: requestOptions.CurrencySymbol,
+		GasLimit:       gasLimit,
+		GasPrice:       gasPrice,
+		Data:           computedData,
+		ChainID:        service.provider.GetNetworkConfig().NetworkID,
+		Version:        transactionVersion,
+	}
 
 	metadataAsObjectsMap, err := toObjectsMap(metadata)
 	if err != nil {

version/constants.go

@@ -5,9 +5,9 @@ const (
 	RosettaVersion = "v1.4.12"
 
 	// RosettaMiddlewareVersion is the version of this package (application)
-	RosettaMiddlewareVersion = "v0.2.8"
+	RosettaMiddlewareVersion = "v0.3.0"
 
 	// NodeVersion is the canonical version of the node runtime
 	// TODO: We should fetch this from node/status.
-	NodeVersion = "v1.3.43-rosetta1"
+	NodeVersion = "v1.3.44-rosetta1"
 )