Integrate message signing #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdan-rosianu
requested changes
Jul 15, 2021
src/interface.ts
Outdated
| @@ -124,6 +129,20 @@ export interface ISignable { | |||
| applySignature(signature: Signature, signedBy: Address): void; | |||
| } | |||
|
|
|||
| /** | |||
| * Interface that defines a signed and verifieble object | |||
| @@ -234,6 +234,10 @@ export class Transaction implements ISignable { | |||
| serializeForSigning(signedBy: Address): Buffer { | |||
| // TODO: for appropriate tx.version, interpret tx.options accordingly and sign using the content / data hash | |||
| let plain = this.toPlainObject(signedBy); | |||
| // Make sure we never sign the transaction with another signature set up (useful when using the same method for verification) | |||
| if (plain.signature) { | |||
There was a problem hiding this comment.
shouldn't this be part of toPlainObject() ?
There was a problem hiding this comment.
no, we should be able to convert toPlainObject while still keeping the signature. The sig removal should only be done while verifying the signature
danielailie
approved these changes
Jul 15, 2021
bogdan-rosianu
approved these changes
Jul 15, 2021
andreibancioiu
added a commit
that referenced
this pull request
Sep 25, 2024
Broadcast transactions, in bulk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code from this PR is in great part integrated thanks to @alexandru-g who opened this PR in the old repo:
https://github.com/ElrondNetwork/elrond-sdk/pull/215/files
There are some modifications though, mostly related to the architecture following the same pattern as our transaction signers. Also all DAPP providers (except HWWallet) throw exceptions on
signMessagebecause the prepended message should be enforced by the provider itself.