-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate message signing #28
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3cad051
initial message signer implementation
ccorcoveanu 5748e02
message signing progress
ccorcoveanu 4d37cf7
finished message signing implementation
ccorcoveanu c8115c9
empty line added
ccorcoveanu 192e707
updated package-lock.json for CI build
ccorcoveanu da90e9b
typo bugfix
ccorcoveanu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
import {ISignable} from "./interface"; | ||
import {Signature} from "./signature"; | ||
const createKeccakHash = require("keccak"); | ||
|
||
export const MESSAGE_PREFIX = "\x17Elrond Signed Message:\n"; | ||
|
||
export class SignableMessage implements ISignable { | ||
|
||
/** | ||
* Actual message being signed. | ||
*/ | ||
message: Buffer; | ||
/** | ||
* Signature obtained by a signer of type @param signer . | ||
*/ | ||
signature: Signature; | ||
|
||
public constructor(init?: Partial<SignableMessage>) { | ||
this.message = Buffer.from([]); | ||
this.signature = new Signature(); | ||
|
||
Object.assign(this, init); | ||
} | ||
|
||
serializeForSigning(): Buffer { | ||
let bytesToHash = Buffer.concat([Buffer.from(MESSAGE_PREFIX), this.message]); | ||
return createKeccakHash("keccak256").update(bytesToHash).digest(); | ||
} | ||
|
||
serializeForSigningRaw(): Buffer { | ||
return this.message; | ||
} | ||
|
||
getSignature(): Signature { | ||
return this.signature; | ||
} | ||
|
||
applySignature(signature: Signature): void { | ||
this.signature = signature; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import {IVerifiable, IVerifier} from "../interface"; | ||
import {Address} from "../address"; | ||
import {UserPublicKey} from "./userKeys"; | ||
|
||
/** | ||
* ed25519 signature verification | ||
*/ | ||
export class UserVerifier implements IVerifier { | ||
|
||
publicKey: UserPublicKey; | ||
constructor(publicKey: UserPublicKey) { | ||
this.publicKey = publicKey; | ||
} | ||
|
||
static fromAddress(address: Address): IVerifier { | ||
let publicKey = new UserPublicKey(address.pubkey()); | ||
return new UserVerifier(publicKey); | ||
} | ||
|
||
/** | ||
* Verify a message's signature. | ||
* @param message the message to be verified. | ||
*/ | ||
verify(message: IVerifiable): boolean { | ||
return this.publicKey.verify( | ||
message.serializeForSigning(this.publicKey.toAddress()), | ||
Buffer.from(message.getSignature().hex(), 'hex')); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be part of
toPlainObject()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, we should be able to convert
toPlainObject
while still keeping the signature. The sig removal should only be done while verifying the signature