Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Feat/proxy-tx-status in main #43

Merged
merged 19 commits into from
Aug 24, 2023
Merged

Merge Feat/proxy-tx-status in main #43

merged 19 commits into from
Aug 24, 2023

Conversation

popenta
Copy link
Contributor

@popenta popenta commented Aug 22, 2023

  • The ApiNetworkProvider has not suffered any changes.

  • The isCompleted field of the TransactionOnNetwork class is now optional.

  • When using the ProxyNetworkProvider to get a transaction's status, we are using the /process-status route.

  • For the proxy provider, the isCompleted field will only be set if ProxyNetworkProvider.getTransaction() is called using withProcessStatus = True.

Here's an example:

let proxy = new ProxyNetworkProvider("https://devnet-gateway.multiversx.com");
let transaction = proxy.getTransaction("txHash", True);

@popenta popenta marked this pull request as draft August 22, 2023 14:07
@popenta popenta marked this pull request as ready for review August 24, 2023 08:01
@popenta popenta merged commit f818208 into main Aug 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants