FIX(ui): User and channel status icons take display scaling into account #5772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, since the inception of the in-line status icons (b39f73b) the status icon size has been hard-coded. In contrast to pretty much all other icons this had the effect, that user display scaling was not taken into account and the status icons appeared too small, if the scaling was >1.0x This commit reverts the static constants for the icon size introduced in 42d74df and calculates the values based on the font size. (This is also done in the TalkingUI for example). In doing so, the icons will resize with the font and therefore with display scaling. Fixes mumble-voip#5632
|
Nice 👍 |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
dexgs
added a commit
to dexgs/mumble
that referenced
this pull request
Aug 22, 2022
Fixed chat log scaling issue introduced by PR mumble-voip#5619 (my fault, whoops) The bug fixed by that commit is still fixed after this PR, but the regression introduced has been resolved. Added minimum icon size for channel status icons which now scale since PR mumble-voip#5772 Initially, icons were too small at 100% scale.
1 task
dexgs
added a commit
to dexgs/mumble
that referenced
this pull request
Aug 22, 2022
Fixed chat log scaling issue introduced by PR mumble-voip#5619 (my fault, whoops) The bug fixed by that commit is still fixed after this PR, but the regression introduced has been resolved. Added minimum icon size for channel status icons which now scale since PR mumble-voip#5772 Initially, icons were too small at 100% scale.
dexgs
added a commit
to dexgs/mumble
that referenced
this pull request
Aug 22, 2022
Fixed chat log scaling issue introduced by PR mumble-voip#5619 (my fault, whoops) The bug fixed by that commit is still fixed after this PR, but the regression introduced has been resolved. Added minimum icon size for channel status icons which now scale since PR mumble-voip#5772 Initially, icons were too small at 100% scale.
1 task
Hartmnt
added a commit
to Hartmnt/mumble
that referenced
this pull request
Aug 22, 2022
Previously (mumble-voip#5772), we implemented a fix to set the status icon size according to the user display scaling. The calculation is based upon font sizes. However, due to an oversight, the wrong font size was used as the base for this calculation. However, the problem was not visible, if by coincidence the correct font size was the same as the one used by accident. This commit changes the calculation of the icon size once again to use the correct font information. Fixes one part of mumble-voip#5817
Hartmnt
added a commit
to Hartmnt/mumble
that referenced
this pull request
Aug 25, 2022
Previously (mumble-voip#5772), we implemented a fix to set the status icon size according to the user display scaling. The calculation is based upon font sizes. However, due to an oversight, the wrong font size was used as the base for this calculation. However, the problem was not visible, if by coincidence the correct font size was the same as the one used by accident. This commit changes the calculation of the icon size once again to use the correct font information. Fixes one part of mumble-voip#5817
Hartmnt
added a commit
to Hartmnt/mumble
that referenced
this pull request
Aug 25, 2022
Previously (mumble-voip#5772), we implemented a fix to set the status icon size according to the user display scaling. The calculation is based upon font sizes. However, due to an oversight, the wrong font size was used as the base for this calculation. However, the problem was not visible, if by coincidence the correct font size was the same as the one used by accident. This commit changes the calculation of the icon size once again to use the correct font information. Fixes one part of mumble-voip#5817
Krzmbrzl
added a commit
that referenced
this pull request
Aug 25, 2022
Previously (#5772), we implemented a fix to set the status icon size according to the user display scaling. The calculation is based upon font sizes. However, due to an oversight, the wrong font size was used as the base for this calculation. However, the problem was not visible, if by coincidence the correct font size was the same as the one used by accident. This commit changes the calculation of the icon size once again to use the correct font information. Fixes one part of #5817
Krzmbrzl
pushed a commit
to Krzmbrzl/mumble
that referenced
this pull request
Sep 8, 2022
Previously (mumble-voip#5772), we implemented a fix to set the status icon size according to the user display scaling. The calculation is based upon font sizes. However, due to an oversight, the wrong font size was used as the base for this calculation. However, the problem was not visible, if by coincidence the correct font size was the same as the one used by accident. This commit changes the calculation of the icon size once again to use the correct font information. Fixes one part of mumble-voip#5817 (cherry picked from commit a587514)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5632 (duplicates: #3773 #3412)
Similar to
TalkingUI, this commit changes the way the size of the user status icons is determined.Should probably be tested on other fractional scaling (I can only do 100% and 200%)