Backport "Merge PR #5772: FIX(ui): User and channel status icons take display scaling into account" to 1.4.x #5779
+44
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, since the inception of the in-line status icons (b39f73b) the status icon size has been hard-coded. In contrast to pretty much all other icons this had the effect, that user display scaling was not taken into account and the status icons appeared too small, if the scaling was >1.0x This commit reverts the static constants for the icon size introduced in 42d74df and calculates the values based on the font size. (This is also done in the TalkingUI for example). In doing so, the icons will resize with the font and therefore with display scaling. Fixes mumble-voip#5632 (cherry picked from commit 1f713cd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
masterto1.4.x:Questions ?
Please refer to the Backport tool documentation