feat: Airplay, Captions, and Cast button props #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #587 +/- ##
==========================================
+ Coverage 77.84% 77.93% +0.09%
==========================================
Files 42 43 +1
Lines 7438 7600 +162
==========================================
+ Hits 5790 5923 +133
- Misses 1648 1677 +29
|
luwes
approved these changes
May 10, 2023
cjpillsbury
approved these changes
May 10, 2023
gkatsev
reviewed
May 11, 2023
|
|
||
| // don't set if the new value is the same as existing | ||
| const newValStr = stringifyTextTrackList(list); | ||
| const oldValStr = stringifyTextTrackList(el.getAttribute(attrName) ?? ''); |
There was a problem hiding this comment.
nit: There's probably no need to stringify the attribute value as it's already stringified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing props for the Airplay, Captions, and Cast buttons.
With captions specifically, we have to decide on the prop type for getting and setting a subtitles list. This is currently a simple array of strings. This matches how we store and retrieve the data from the attribute and also makes interacting with the prop similar to how a dev would interact with the attribute directly.
The alternative is to accept
TextTrack's (or objects that are a subset with only the data we need). Is this preferable? I can see this being simpler for the developer assuming they haveTextTrack's at hand.