-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Airplay, Captions, and Cast button props #587
Merged
AdamJaggard
merged 31 commits into
muxinc:main
from
AdamJaggard:feat/misc-buttons-1-props
May 11, 2023
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
2b0b0b5
props for airplay button
AdamJaggard fefbaac
media captions button props
AdamJaggard dcf6bd2
media captions account for null and comments
AdamJaggard b68cd4d
airplay button handle null
AdamJaggard d58130a
cast to string for anything remaining
AdamJaggard bc66b6b
cast button props
AdamJaggard c62e3cc
fix attr type
AdamJaggard 2237983
treat subtitlesshowing the same as subtitleslist, move to utils in sa…
AdamJaggard d896e0f
remove random slashes
AdamJaggard e1762c8
remove informal public getters mediaSeekableEnd and mediaSeekableStart
AdamJaggard 7e0901e
define attribute lists up front
AdamJaggard d92d6c4
lint
AdamJaggard 9ea3c87
new setters and jsdoc comments
AdamJaggard 5014127
type private prop
AdamJaggard 0478f38
remove unneeded manual updates
AdamJaggard 074f5a7
simplify attribute toggling
AdamJaggard 678a9bd
don't update attribute if value hasn't changed
AdamJaggard 83a321f
use @type and remove unnecessary setter annotations
AdamJaggard d7ebc21
allow undefined in mediaSeekable setter
AdamJaggard a234c08
allow undefined for setting current time
AdamJaggard fd207d2
update current time getter and setter
AdamJaggard 1af0798
update duration getter and setter
AdamJaggard 1bda9fa
element attr utility functions
AdamJaggard 0a040b3
prettier lint
AdamJaggard 2f5d477
string attr utils
AdamJaggard 4bab806
use new utils
AdamJaggard 33f55d6
fix import
AdamJaggard 88193bc
comments
AdamJaggard d9be1c6
captions -> subtitles
AdamJaggard 0f53da7
accept array of texttrack-like objects
AdamJaggard 9b87af6
remove getAttribute
AdamJaggard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: There's probably no need to stringify the attribute value as it's already stringified.