#3 added assertions to local and pull-request config

mvogelgesang · Jan 8, 2023 · 32501d0 · 32501d0
1 parent 9d969ae
commit 32501d0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/lighthouserc_firebase.json b/lighthouserc_firebase.json
@@ -1,13 +1,16 @@
 {
   "ci": {
-    "upload": {
-      "target": "temporary-public-storage"
-    },
     "assert": {
       "assertions": {
+        "categories:accessibility": ["error", {"minScore": 1}],
+        "categories:best-practices": ["error", {"minScore": 1}],
         "categories:performance": ["error", {"minScore": 0.95}],
-        "categories:accessibility": ["error", {"minScore": 1}]
+        "categories:pwa": ["error", {"minScore": 1}],
+        "categories:seo": ["error", {"minScore": 1}]
       }
+    },
+    "upload": {
+      "target": "temporary-public-storage"
     }
   }
 }
diff --git a/lighthouserc_local.json b/lighthouserc_local.json
@@ -2,8 +2,11 @@
   "ci": {
     "assert": {
       "assertions": {
+        "categories:accessibility": ["error", {"minScore": 1}],
+        "categories:best-practices": ["error", {"minScore": 1}],
         "categories:performance": ["error", {"minScore": 0.95}],
-        "categories:accessibility": ["error", {"minScore": 1}]
+        "categories:pwa": ["error", {"minScore": 1}],
+        "categories:seo": ["error", {"minScore": 1}]
       }
     },
     "collect": {