Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pa11y integration with gh-actions #3

Open
4 tasks
mvogelgesang opened this issue Sep 18, 2021 · 0 comments
Open
4 tasks

add pa11y integration with gh-actions #3

mvogelgesang opened this issue Sep 18, 2021 · 0 comments

Comments

@mvogelgesang
Copy link
Owner

mvogelgesang commented Sep 18, 2021 •
edited
Loading

Acceptance Criteria

  • should test all urls
  • should ignore any content included by reference (Gists)
  • should work locally, on test Firebase urls, and production (mvogelgesang.com)
  • all urls pass

References
mvogelgesang added a commit that referenced this issue Dec 11, 2021
@mvogelgesang
#3 updated scripts
bf59069
mvogelgesang added a commit that referenced this issue Dec 12, 2021
@mvogelgesang
#3 created vscode workspace
2a63c73
mvogelgesang added a commit that referenced this issue Jan 6, 2023
@mvogelgesang
#3 implemented lighthouse ci, need to test GHA
c13d5f2
mvogelgesang added a commit that referenced this issue Jan 6, 2023
@mvogelgesang
#3 updated formatting of yaml file
74af3d4
mvogelgesang added a commit that referenced this issue Jan 6, 2023
@mvogelgesang
#3 split install and lhci into separate commands
a5d6b9f
mvogelgesang added a commit that referenced this issue Jan 6, 2023
@mvogelgesang
#3 wrapped id in single quotes
77dc8f4
mvogelgesang added a commit that referenced this issue Jan 6, 2023
@mvogelgesang
#3 fixed indenting
07b5f34
mvogelgesang added a commit that referenced this issue Jan 6, 2023
@mvogelgesang
#3 per https://docs.github.com/en/actions/using-jobs/defining-outputs…
1f8082a 
…-for-jobs\#example-defining-outputs-for-a-job
mvogelgesang added a commit that referenced this issue Jan 6, 2023
@mvogelgesang
#3 see if it works as a single job
b89c698
mvogelgesang added a commit that referenced this issue Jan 6, 2023
@mvogelgesang
#3 added id to the firebase deploy operation step
3e9b13c
mvogelgesang added a commit that referenced this issue Jan 6, 2023
@mvogelgesang
#3 switched run back to multi with |
3ec84f5
mvogelgesang added a commit that referenced this issue Jan 6, 2023
@mvogelgesang
#3 set ci operation to not load local config and instead rely on inpu…
b89a7a0 
…ts saved in the GHA workflow
mvogelgesang added a commit that referenced this issue Jan 6, 2023
@mvogelgesang
#3 did not honor skipping local config, created firebase config
36b6415
mvogelgesang added a commit that referenced this issue Jan 6, 2023
@mvogelgesang
#3 did not honor skipping local config, created firebase config, actu…
1b94284 
…ally committing this time
mvogelgesang added a commit that referenced this issue Jan 7, 2023
@mvogelgesang
#3 updates after running locally against preview instance
67872f4
mvogelgesang added a commit that referenced this issue Jan 7, 2023
@mvogelgesang
#3 pulling single url versus multiple
0e984d5
mvogelgesang added a commit that referenced this issue Jan 7, 2023
@mvogelgesang
#3 moving fontawesome js to bottom of pagewrapper component to speed …
de2f092 
…up page load time
mvogelgesang added a commit that referenced this issue Jan 7, 2023
@mvogelgesang
#3 updated PWA attributes to contain correct icons and theme colors. …
6861e2c 
…Added aria-label to footer icons
mvogelgesang added a commit that referenced this issue Jan 7, 2023
@mvogelgesang
#3 failed to commit basehea and footer components
ccaf499
mvogelgesang added a commit that referenced this issue Jan 7, 2023
@mvogelgesang
#3 updated package.json to includ lhci test
a4b6606
mvogelgesang added a commit that referenced this issue Jan 7, 2023
@mvogelgesang
#3 updated name of workflow rule and added env var, added performance…
9d969ae 
… and accessibility assertion
mvogelgesang added a commit that referenced this issue Jan 8, 2023
@mvogelgesang
#3 added assertions to local and pull-request config
32501d0
mvogelgesang added a commit that referenced this issue Jan 8, 2023
@mvogelgesang
#3 provided name to workflow job
3c14b81
mvogelgesang added a commit that referenced this issue Jan 8, 2023
@mvogelgesang
#3 implemented lighthouse ci, need to test GHA (#30)
5bd5a60 
* #3 implemented lighthouse ci
* #3 per https://docs.github.com/en/actions/using-jobs/defining-outputs-for-jobs\#example-defining-outputs-for-a-job
* #3 did not honor skipping local config, created firebase config
* #3 pulling single url versus multiple
* #3 moving fontawesome js to bottom of pagewrapper component to speed up page load time
* #3 updated PWA attributes to contain correct icons and theme colors. Added aria-label to footer icons
* #3 updated package.json to includ lhci test
* #3 added assertions to local and pull-request config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mvogelgesang