Allow customizing the quinn::TransportConfig in iroh::node::Builder

[flub]

The iroh::node::Builder sets the max_concurrent_uni_streams to 0 (i.e. none) and max_concurrent_bidi_streams to 10 (i.e. barely any).

Furthermore it does not allow customising these values.

• It should not set default values other than the Quinn defaults probably.
• It should allow for a custom TransportConfig to be used.

[matheus23]

#2593 fixes the first point, but does not yet allow for a custom TransportConfig. Editing the title.

[divagant-martian]

We have

iroh/iroh-net/src/endpoint.rs

Lines 214 to 225 in 1d3f3fa

	/// Sets a custom [`quinn::TransportConfig`] for this endpoint.
	///
	/// The transport config contains parameters governing the QUIC state machine.
	///
	/// If unset, the default config is used. Default values should be suitable for most
	/// internet applications. Applications protocols which forbid remotely-initiated
	/// streams should set `max_concurrent_bidi_streams` and `max_concurrent_uni_streams` to
	/// zero.
	pub fn transport_config(mut self, transport_config: quinn::TransportConfig) -> Self {
	self.transport_config = Some(transport_config);
	self
	}

which has been around for awhile. You updated it's docs in #2334 and I thought it was added in that PR due to re-ordering but it was added in #1133, more than a year ago.

Is there something else missing?

[matheus23]

Oh, I missed that. In that case we can probably close this, right?

[flub]

We have

iroh/iroh-net/src/endpoint.rs

Lines 214 to 225 in 1d3f3fa

	/// Sets a custom [`quinn::TransportConfig`] for this endpoint.
	///
	/// The transport config contains parameters governing the QUIC state machine.
	///
	/// If unset, the default config is used. Default values should be suitable for most
	/// internet applications. Applications protocols which forbid remotely-initiated
	/// streams should set `max_concurrent_bidi_streams` and `max_concurrent_uni_streams` to
	/// zero.
	pub fn transport_config(mut self, transport_config: quinn::TransportConfig) -> Self {
	self.transport_config = Some(transport_config);
	self
	}

This is in iroh-net. The issue is about the iroh::node::Builder which I think is distinct from using iroh-net on it's own.

I'm not really sure about what should be in the iroh::node::Node, but I gather it's a larger system that build on iroh-net but still allows you to drop down to iroh-net and write your own additional protocols.

[divagant-martian]

that makes sense, thanks!

[Frando]

We could also allow passing an iroh_net::Endpoint to iroh::node::Builder I think. We have some different defaults though atm (iroh sets discovery whereas iroh_net does not)