fix(iroh): Do not set low max streams in builder #2593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the max streams in the builder. This makes little sense when users are allowed to create their custom protocol. right now both uni and bidirectional streams default to 100 max, which is reasonable for now. We should allow fully customising the TransportConfig later.
dignifiedquire
approved these changes
Aug 5, 2024
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2593/docs/iroh/ Last updated: 2024-08-05T20:12:33Z |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the max streams in the builder. This makes little sense
when users are allowed to create their custom protocol.
right now both uni and bidirectional streams default to 100 max, which
is reasonable for now. We should allow fully customising the
TransportConfig later.
Breaking Changes
I don't think this counts as a breaking change. If we want to lower
one of these later it would be, but we're probably fine with 100 by
default?
Notes & open questions
See #2592
Change checklist