Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iroh): Do not set low max streams in builder #2593

Merged
merged 1 commit into from
Aug 5, 2024
Merged

fix(iroh): Do not set low max streams in builder #2593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions iroh/src/node/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ const ENDPOINT_WAIT: Duration = Duration::from_secs(5);
const DEFAULT_GC_INTERVAL: Duration = Duration::from_secs(60 * 5);

const MAX_CONNECTIONS: u32 = 1024;
const MAX_STREAMS: u64 = 10;

/// Storage backend for documents.
#[derive(Debug, Clone)]
Expand Down Expand Up @@ -458,11 +457,6 @@ where
..Default::default()
});
let (endpoint, nodes_data_path) = {
let mut transport_config = quinn::TransportConfig::default();
transport_config
.max_concurrent_bidi_streams(MAX_STREAMS.try_into()?)
.max_concurrent_uni_streams(0u32.into());

let discovery: Option<Box<dyn Discovery>> = match self.node_discovery {
DiscoveryConfig::None => None,
DiscoveryConfig::Custom(discovery) => Some(discovery),
Expand Down Expand Up @@ -501,7 +495,6 @@ where
.secret_key(self.secret_key.clone())
.proxy_from_env()
.keylog(self.keylog)
.transport_config(transport_config)
.concurrent_connections(MAX_CONNECTIONS)
.relay_mode(self.relay_mode);
let endpoint = match discovery {
Expand Down
Loading