fix(HTTP Request Node): Delete response.request only when it's a va…

…lid circular references (#8293)
n8n-io · Jan 10, 2024 · 05c43fa · 05c43fa
1 parent 8c7f399
commit 05c43fa
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/packages/nodes-base/nodes/HttpRequest/V1/HttpRequestV1.node.ts b/packages/nodes-base/nodes/HttpRequest/V1/HttpRequestV1.node.ts
@@ -994,7 +994,7 @@ export class HttpRequestV1 implements INodeType {
 			}
 
 			response = response.value;
-			delete response.request;
+			if (response?.request?.constructor.name === 'ClientRequest') delete response.request;
 
 			const options = this.getNodeParameter('options', itemIndex, {});
 

diff --git a/packages/nodes-base/nodes/HttpRequest/V2/HttpRequestV2.node.ts b/packages/nodes-base/nodes/HttpRequest/V2/HttpRequestV2.node.ts
@@ -1047,7 +1047,7 @@ export class HttpRequestV2 implements INodeType {
 			}
 
 			response = response.value;
-			delete response.request;
+			if (response?.request?.constructor.name === 'ClientRequest') delete response.request;
 
 			const options = this.getNodeParameter('options', itemIndex, {});
 

diff --git a/packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts b/packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts
@@ -1786,7 +1786,8 @@ export class HttpRequestV3 implements INodeType {
 
 			// eslint-disable-next-line prefer-const
 			for (let [index, response] of Object.entries(responses)) {
-				delete response.request;
+				if (response?.request?.constructor.name === 'ClientRequest') delete response.request;
+
 				if (this.getMode() === 'manual' && index === '0') {
 					// For manual executions save the first response in the context
 					// so that we can use it in the frontend and so make it easier for