fix(editor): Fix success state for disabled nodes in new canvas (no-c…

…hangelog) (#11039)
n8n-io · Oct 1, 2024 · 3191912 · 3191912
1 parent e04b980
commit 3191912
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/packages/editor-ui/src/components/canvas/elements/nodes/render-types/CanvasNodeDefault.vue b/packages/editor-ui/src/components/canvas/elements/nodes/render-types/CanvasNodeDefault.vue
@@ -118,7 +118,7 @@ function openContextMenu(event: MouseEvent) {
 				<FontAwesomeIcon icon="bolt" size="lg" />
 			</div>
 		</N8nTooltip>
-		<CanvasNodeStatusIcons :class="$style.statusIcons" />
+		<CanvasNodeStatusIcons v-if="!isDisabled" :class="$style.statusIcons" />
 		<CanvasNodeDisabledStrikeThrough v-if="isStrikethroughVisible" />
 		<div :class="$style.description">
 			<div v-if="label" :class="$style.label">

diff --git a/...c/components/canvas/elements/nodes/render-types/parts/CanvasNodeDisabledStrikeThrough.vue b/...c/components/canvas/elements/nodes/render-types/parts/CanvasNodeDisabledStrikeThrough.vue
@@ -1,18 +1,15 @@
 <script setup lang="ts">
 import { computed, useCssModule } from 'vue';
+import { useCanvasNode } from '@/composables/useCanvasNode';
 
 const $style = useCssModule();
 
-const isSuccessStatus = computed(
-	() => false,
-	// @TODO Implement this
-	// () => !['unknown'].includes(node.status) && workflowDataItems > 0,
-);
+const { hasRunData } = useCanvasNode();
 
 const classes = computed(() => {
 	return {
 		[$style.disabledStrikeThrough]: true,
-		[$style.success]: isSuccessStatus.value,
+		[$style.success]: hasRunData.value,
 	};
 });
 </script>