Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix success state for disabled nodes in new canvas (no-changelog) #11039

Conversation

alexgrozav
Copy link
Contributor

Summary

image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/N8N-7608/deactivating-a-node-does-not-prevent-it-from-being-executed

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Oct 1, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Oct 1, 2024

n8n    Run #7116

Run Properties:  status check passed Passed #7116  •  git commit 3191912168: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project n8n
Branch Review master
Run status status check passed Passed #7116
Run duration 04m 29s
Commit git commit 3191912168: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 437
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Oct 1, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

github-actions bot commented Oct 1, 2024

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit 3191912 into master Oct 1, 2024
33 checks passed
@alexgrozav alexgrozav deleted the n8n-7608-deactivating-a-node-does-not-prevent-it-from-being-executed branch October 1, 2024 18:06
@janober
Copy link
Member

janober commented Oct 2, 2024

Got released with n8n@1.62.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants