-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(editor): Overhaul document title management (#10999)
- Loading branch information
Showing
31 changed files
with
155 additions
and
83 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
packages/editor-ui/src/composables/__tests__/useDocumentTitle.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import { mock } from 'vitest-mock-extended'; | ||
import { describe, it, expect } from 'vitest'; | ||
import type { FrontendSettings } from '@n8n/api-types'; | ||
import { useDocumentTitle } from '../useDocumentTitle'; | ||
|
||
const settings = mock<FrontendSettings>({ releaseChannel: 'stable' }); | ||
vi.mock('@/stores/settings.store', () => ({ | ||
useSettingsStore: vi.fn(() => ({ settings })), | ||
})); | ||
|
||
describe('useDocumentTitle', () => { | ||
it('should set the document title', () => { | ||
const { set } = useDocumentTitle(); | ||
set('Test Title'); | ||
expect(document.title).toBe('Test Title - n8n'); | ||
}); | ||
|
||
it('should reset the document title', () => { | ||
const { set, reset } = useDocumentTitle(); | ||
set('Test Title'); | ||
reset(); | ||
expect(document.title).toBe('Workflow Automation - n8n'); | ||
}); | ||
|
||
it('should use the correct prefix for the release channel', () => { | ||
settings.releaseChannel = 'beta'; | ||
const { set } = useDocumentTitle(); | ||
set('Test Title'); | ||
expect(document.title).toBe('Test Title - n8n[BETA]'); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import { useSettingsStore } from '@/stores/settings.store'; | ||
|
||
const DEFAULT_TITLE = 'Workflow Automation'; | ||
|
||
export function useDocumentTitle() { | ||
const settingsStore = useSettingsStore(); | ||
const { releaseChannel } = settingsStore.settings; | ||
const suffix = | ||
!releaseChannel || releaseChannel === 'stable' ? 'n8n' : `n8n[${releaseChannel.toUpperCase()}]`; | ||
|
||
const set = (title: string) => { | ||
const sections = [title || DEFAULT_TITLE, suffix]; | ||
document.title = sections.join(' - '); | ||
}; | ||
|
||
const reset = () => { | ||
set(''); | ||
}; | ||
|
||
return { set, reset }; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.