Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editor): Overhaul document title management #10999

Merged
merged 3 commits into from
Sep 30, 2024
Merged

feat(editor): Overhaul document title management #10999

merged 3 commits into from
Sep 30, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Sep 27, 2024 •
edited
Loading

Summary

This PR overhaul the code that updates document.title, and also updates most of the views to set relevant titles.

Related Linear tickets, Github issues, and Community forum posts

Fixes #8861
CAT-78

Review / Merge checklist

  • PR title and summary are descriptive
  • Tests included

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 27, 2024
alexgrozav
alexgrozav requested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! One small remark regarding the release channel

packages/editor-ui/src/composables/useDocumentTitle.ts Outdated Show resolved Hide resolved
alexgrozav
alexgrozav approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the suggestions!

@cypress Cypress
Copy link

cypress bot commented Sep 30, 2024

n8n    Run #7089

Run Properties:  status check passed Passed #7089  •  git commit 13325c554d: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project n8n
Branch Review fix-CAT-78-document-title
Run status status check passed Passed #7089
Run duration 04m 26s
Commit git commit 13325c554d: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Committer कारतोफ्फेलस्क्रिप्ट™
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 435
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit bb28956 into master Sep 30, 2024
33 checks passed
@netroy netroy deleted the fix-CAT-78-document-title branch September 30, 2024 08:57
MiloradFilipovic added a commit that referenced this pull request Sep 30, 2024
@MiloradFilipovic
Merge branch 'master' into ADO-2659-context-to-support-chat
958fc56 
* master:
  feat(editor): Overhaul document title management (#10999)
  refactor(core): Organize all event maps (#10997)
  fix(AI Agent Node): Fix output parsing and empty tool input handling in AI Agent node (#10970)
This was referenced Oct 2, 2024
Merged
Merged
@janober
Copy link
Member

janober commented Oct 2, 2024

Got released with n8n@1.62.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgrozav alexgrozav alexgrozav approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page title not always updated
3 participants
@netroy @janober @alexgrozav