Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(OpenAI Model Node Node, Google PaLM Language Model Node, Google PaLM Chat Model Node): Mark nodes as deprecated #10119

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

OlegIvaniv
Copy link
Contributor

Summary

Mark the following LLM nodes as deprecated:

  • OpenAI Model Node Node
  • Google PaLM Language Model Node
  • Google PaLM Chat Model Node

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 19, 2024
@jeanpaul
Copy link
Contributor

LGTM

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jul 19, 2024

3 flaky tests on run #6039 ↗︎

0 400 0 0 Flakiness 3

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project: n8n Commit: c543297242
Status: Passed Duration: 05:05 💡
Started: Jul 19, 2024 3:29 PM Ended: Jul 19, 2024 3:34 PM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
Flakiness  20-workflow-executions.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Current Workflow Executions > should auto load more items if there is space and auto scroll Test Replay Screenshots Video
Flakiness  25-stickies.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Canvas Actions > change sticky color Test Replay Screenshots Video

Review all test suite changes for PR #10119 ↗︎

@OlegIvaniv OlegIvaniv changed the title chore(OpenAI Model Node Node, Google PaLM Language Model Node, Google PaLM Chat Model Node): Mark nodes as deprecated refactor(OpenAI Model Node Node, Google PaLM Language Model Node, Google PaLM Chat Model Node): Mark nodes as deprecated Jul 19, 2024
@OlegIvaniv OlegIvaniv requested a review from jeanpaul July 19, 2024 15:23
Copy link
Contributor

✅ All Cypress E2E specs passed

@OlegIvaniv OlegIvaniv merged commit a8b5551 into master Jul 19, 2024
26 of 27 checks passed
@OlegIvaniv OlegIvaniv deleted the ai-228-hide-the-old-openai-model-thats-deprecated branch July 19, 2024 15:57
@janober
Copy link
Member

janober commented Jul 24, 2024

Got released with n8n@1.52.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants