Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(OpenAI Model Node Node, Google PaLM Language Model Node, Google PaLM Chat Model Node): Mark nodes as deprecated #10119

Merged
merged 4 commits into from
Jul 19, 2024
Merged

refactor(OpenAI Model Node Node, Google PaLM Language Model Node, Google PaLM Chat Model Node): Mark nodes as deprecated #10119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a1fb5d
chore(OpenAI Model Node Node, Google PaLM Language Model Node, Google…
OlegIvaniv Jul 19, 2024
7790dcd
Fix linting issues
OlegIvaniv Jul 19, 2024
bcfaa2b
Merge branch 'master' into ai-228-hide-the-old-openai-model-thats-dep…
OlegIvaniv Jul 19, 2024
c543297
Merge branch 'master' into ai-228-hide-the-old-openai-model-thats-dep…
OlegIvaniv Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/@n8n/nodes-langchain/nodes/llms/LMOpenAi/LmOpenAi.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import type {
} from 'n8n-workflow';

import { OpenAI, type ClientOptions } from '@langchain/openai';
import { getConnectionHintNoticeField } from '../../../utils/sharedFields';
import { N8nLlmTracing } from '../N8nLlmTracing';

type LmOpenAiOptions = {
Expand All @@ -28,6 +27,7 @@ export class LmOpenAi implements INodeType {
displayName: 'OpenAI Model',
// eslint-disable-next-line n8n-nodes-base/node-class-description-name-miscased
name: 'lmOpenAi',
hidden: true,
icon: { light: 'file:openAiLight.svg', dark: 'file:openAiLight.dark.svg' },
group: ['transform'],
version: 1,
Expand Down Expand Up @@ -65,7 +65,13 @@ export class LmOpenAi implements INodeType {
'={{ $parameter.options?.baseURL?.split("/").slice(0,-1).join("/") || "https://api.openai.com" }}',
},
properties: [
getConnectionHintNoticeField([NodeConnectionType.AiChain, NodeConnectionType.AiAgent]),
{
displayName:
'This node is using OpenAI completions which are now deprecated. Please use the OpenAI Chat Model node instead.',
name: 'deprecated',
type: 'notice',
default: '',
},
{
displayName: 'Model',
name: 'model',
Expand Down
10 changes: 8 additions & 2 deletions packages/@n8n/nodes-langchain/nodes/llms/LmChatGooglePalm/LmChatGooglePalm.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import {
type SupplyData,
} from 'n8n-workflow';
import { ChatGooglePaLM } from '@langchain/community/chat_models/googlepalm';
import { getConnectionHintNoticeField } from '../../../utils/sharedFields';
import { N8nLlmTracing } from '../N8nLlmTracing';

export class LmChatGooglePalm implements INodeType {
Expand All @@ -16,6 +15,7 @@ export class LmChatGooglePalm implements INodeType {
// eslint-disable-next-line n8n-nodes-base/node-class-description-name-miscased
name: 'lmChatGooglePalm',
icon: 'file:google.svg',
hidden: true,
group: ['transform'],
version: 1,
description: 'Chat Model Google PaLM',
Expand Down Expand Up @@ -51,7 +51,13 @@ export class LmChatGooglePalm implements INodeType {
baseURL: '={{ $credentials.host }}',
},
properties: [
getConnectionHintNoticeField([NodeConnectionType.AiChain, NodeConnectionType.AiAgent]),
{
displayName:
"Google PaLM API is <a href='https://ai.google.dev/palm_docs/deprecation' target='_blank'>deprecated</a>. Please use Google Vertex or Google Gemini nodes instead.",
name: 'deprecated',
type: 'notice',
default: '',
},
{
displayName: 'Model',
name: 'modelName',
Expand Down
2 changes: 1 addition & 1 deletion packages/@n8n/nodes-langchain/nodes/llms/LmChatGoogleVertex/LmChatGoogleVertex.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ import type { SafetySetting } from '@google/generative-ai';
import { ProjectsClient } from '@google-cloud/resource-manager';
import { getConnectionHintNoticeField } from '../../../utils/sharedFields';
import { N8nLlmTracing } from '../N8nLlmTracing';
import { makeErrorFromStatus } from './error-handling';
import { additionalOptions } from '../gemini-common/additional-options';
import { makeErrorFromStatus } from './error-handling';

export class LmChatGoogleVertex implements INodeType {
description: INodeTypeDescription = {
Expand Down
10 changes: 8 additions & 2 deletions packages/@n8n/nodes-langchain/nodes/llms/LmGooglePalm/LmGooglePalm.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ import {
type SupplyData,
} from 'n8n-workflow';
import { GooglePaLM } from '@langchain/community/llms/googlepalm';
import { getConnectionHintNoticeField } from '../../../utils/sharedFields';
import { N8nLlmTracing } from '../N8nLlmTracing';

export class LmGooglePalm implements INodeType {
description: INodeTypeDescription = {
displayName: 'Google PaLM Language Model',
// eslint-disable-next-line n8n-nodes-base/node-class-description-name-miscased
name: 'lmGooglePalm',
hidden: true,
icon: 'file:google.svg',
group: ['transform'],
version: 1,
Expand Down Expand Up @@ -51,7 +51,13 @@ export class LmGooglePalm implements INodeType {
baseURL: '={{ $credentials.host }}',
},
properties: [
getConnectionHintNoticeField([NodeConnectionType.AiChain, NodeConnectionType.AiAgent]),
{
displayName:
"Google PaLM API is <a href='https://ai.google.dev/palm_docs/deprecation' target='_blank'>deprecated</a>. Please use Google Vertex or Google Gemini nodes instead.",
name: 'deprecated',
type: 'notice',
default: '',
},
{
displayName: 'Model',
name: 'modelName',
Expand Down
2 changes: 1 addition & 1 deletion packages/editor-ui/src/components/RunData.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1080,7 +1080,7 @@ export default defineComponent({
},
watch: {
node(newNode: INodeUi, prevNode: INodeUi) {
if (newNode.id === prevNode.id) return;
if (newNode?.id === prevNode?.id) return;
this.init();
},
hasNodeRun() {
Expand Down
Loading