Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Fix missing successful items on continueErrorOutput with multiple outputs #10218

Merged
merged 8 commits into from
Jul 29, 2024
Merged

fix(core): Fix missing successful items on continueErrorOutput with multiple outputs #10218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0bd173a
Fix missing successful items on continueErrorOutput with multiple out…
jeanpaul Jul 26, 2024
4b34656
Add test for multi-output nodes with continueErrorOutput
jeanpaul Jul 29, 2024
a1522bf
Don't copy successItems if it's not necessary
jeanpaul Jul 29, 2024
7b0befb
Don't test the if-output for now
jeanpaul Jul 29, 2024
6fd3330
Add option to test all outputs, not just the first one
jeanpaul Jul 29, 2024
57effae
Make sure the returnData is always the same type
jeanpaul Jul 29, 2024
85b014f
Use NodeConnectionType.Main instead of the json-variant 'main'
jeanpaul Jul 29, 2024
58bf6c2
Remove test:wf command used for just testing the workflow tests
jeanpaul Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/core/src/WorkflowExecute.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1125,7 +1125,6 @@ export class WorkflowExecute {
);

const errorItems: INodeExecutionData[] = [];
const successItems: INodeExecutionData[] = [];
const closeFunctions: CloseFunction[] = [];
// Create a WorkflowDataProxy instance that we can get the data of the
// item which did error
Expand All @@ -1150,8 +1149,10 @@ export class WorkflowExecute {
outputIndex < mainOutputTypes.length - 1;
outputIndex++
) {
successItems.length = 0;
const items = nodeSuccessData.length ? nodeSuccessData[0] : [];
const successItems: INodeExecutionData[] = [];
const items = nodeSuccessData[outputIndex]?.length
? nodeSuccessData[outputIndex]
: [];

while (items.length) {
const item = items.pop();
Expand Down
5 changes: 4 additions & 1 deletion packages/core/test/WorkflowExecute.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,10 @@ describe('WorkflowExecute', () => {
if (nodeData.data === undefined) {
return null;
}
return nodeData.data.main[0]!.map((entry) => entry.json);
const toMap = testData.output.testAllOutputs
? nodeData.data.main
: [nodeData.data.main[0]!];
return toMap.map((data) => data!.map((entry) => entry.json));
});

// expect(resultData).toEqual(testData.output.nodeData[nodeName]);
Expand Down
Loading
Loading