fix(core): Fix missing successful items on continueErrorOutput with multiple outputs #10218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…puts When testing the `continueOnFail` behavior for the Text Classifier Node, I noticed that the successful items were missing from the non-error outputs. I traced it to the re-use of `successItems` and referencing the wrong output to get the items.
n8n-assistant
bot
added
core
Disable this output testing, because the resultData is not giving both output streams, weirdly enough. Testing the set-fields after is good enough.
netroy
requested changes
Jul 29, 2024
This meant updating the tests, to account for the different outputs.
netroy
changed the title
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
|
✅ All Cypress E2E specs passed |
jeanpaul
deleted the
pay-1786-continue-on-fail-output-to-error-stream-doesnt-work-properly
branch
MiloradFilipovic
added a commit
that referenced
this pull request
Jul 30, 2024
* master: docs: Update login url for OpenAI node (no-changelog) (#10222) fix(LinkedIn Node): Fix issue with some characters cutting off posts early (#10185) fix(Google BigQuery Node): Send timeoutMs in query, pagination support (#10205) feat(core): Show Public API key value only once (no-changelog) (#10126) refactor(core): Display stack trace in error reporter (no-changelog) (#10225) fix(core): Fix missing successful items on continueErrorOutput with multiple outputs (#10218) fix(n8n Form Trigger Node): Remove custom attribution option (no-changelog) (#10229) feat(n8n Form Trigger Node): Improvements (#10092) refactor(core): Port path, host, port, listen_address and protocol config (no-changelog) (#10223) docs: Update add options text (no-changelog) (#10049) fix(Postgres Node): Option to treat query parameters enclosed in single quotas as text (#10214) refactor(core): Decouple server started event from internal hooks (no-changelog) (#10221) feat(Shopify Node): Update Shopify API version (#10155) fix(editor): Defer `User saved credentials` telemetry event for OAuth credentials (#10215) fix(editor): Fix parameter input glitch when there was an error loading remote options (#10209)
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing the
continueOnFailbehavior for the Text Classifier Node, I noticed that the successful items were missing from the non-error outputs. I traced it to the re-use ofsuccessItemsand referencing the wrong output to get the items.Summary
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-1786/continue-on-fail-output-to-error-stream-doesnt-work-properly-with
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)