refactor(core): Decouple server started event from internal hooks (no-changelog) #10221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
commented
Jul 29, 2024
Comment on lines
+486
to
+490
| const firstWorkflow = await this.workflowRepository.findOne({ | ||
| select: ['createdAt'], | ||
| order: { createdAt: 'ASC' }, | ||
| where: {}, | ||
| }); |
There was a problem hiding this comment.
Initially tried to pass this as an event arg from Server but importing the workflow repository there leads to ServiceNotFoundError: Service with "MaybeConstructable<DataSource>" identifier was not found in the container. Register it before usage via explicitly calling the "Container.set" function or using the "@Service()" decorator.
There was a problem hiding this comment.
Leaving this in Server meant that this query would have run even if telemetry was disabled. This file is the correct place for this query.
ivov
commented
Jul 29, 2024
There was a problem hiding this comment.
I was thinking to bring this back later, else let me know if we should rewrite it now.
netroy
reviewed
Jul 29, 2024
netroy
approved these changes
Jul 29, 2024
Comment on lines
+486
to
+490
| const firstWorkflow = await this.workflowRepository.findOne({ | ||
| select: ['createdAt'], | ||
| order: { createdAt: 'ASC' }, | ||
| where: {}, | ||
| }); |
There was a problem hiding this comment.
Leaving this in Server meant that this query would have run even if telemetry was disabled. This file is the correct place for this query.
n8n-assistant
bot
added
core
|
|
1 flaky test on run #6175 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Data pinning > should use pin data in manual executions that are started by a webhook |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #10221 ↗︎
|
✅ All Cypress E2E specs passed |
ivov
added a commit
that referenced
this pull request
Jul 29, 2024
…oks (no-changelog) Follow-up to: #10221
MiloradFilipovic
added a commit
that referenced
this pull request
Jul 30, 2024
* master: docs: Update login url for OpenAI node (no-changelog) (#10222) fix(LinkedIn Node): Fix issue with some characters cutting off posts early (#10185) fix(Google BigQuery Node): Send timeoutMs in query, pagination support (#10205) feat(core): Show Public API key value only once (no-changelog) (#10126) refactor(core): Display stack trace in error reporter (no-changelog) (#10225) fix(core): Fix missing successful items on continueErrorOutput with multiple outputs (#10218) fix(n8n Form Trigger Node): Remove custom attribution option (no-changelog) (#10229) feat(n8n Form Trigger Node): Improvements (#10092) refactor(core): Port path, host, port, listen_address and protocol config (no-changelog) (#10223) docs: Update add options text (no-changelog) (#10049) fix(Postgres Node): Option to treat query parameters enclosed in single quotas as text (#10214) refactor(core): Decouple server started event from internal hooks (no-changelog) (#10221) feat(Shopify Node): Update Shopify API version (#10155) fix(editor): Defer `User saved credentials` telemetry event for OAuth credentials (#10215) fix(editor): Fix parameter input glitch when there was an error loading remote options (#10209)
cstuncsik
pushed a commit
that referenced
this pull request
Jul 31, 2024
ivov
added a commit
that referenced
this pull request
Jul 31, 2024
… internal hooks (no-changelog) Follow-up to #10221
|
Got released with |
cstuncsik
pushed a commit
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #10162