fix(core): Flush instance stopped event immediately #10238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rudderstack flushes events after 20 events have been batched or 10 seconds have elapsed since the last flush. Since we were waiting for the 'User instance stopped' event to be sent before calling flush, we might have waited up to 10 seconds before the event got sent. Instead call the flush right away to send the stopped and any other remaining events immediately.
n8n-assistant
bot
added
core
netroy
reviewed
Jul 30, 2024
We are not actually waiting for the track & identify events anywhere, so it doesn't make sense to have the method async.
netroy
approved these changes
Jul 30, 2024
|
Test summaryRun details
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
||||||||||||||||||||||||||
|
✅ All Cypress E2E specs passed |
|
Got released with |
cstuncsik
pushed a commit
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rudderstack flushes events after 20 events have been batched or
10 seconds have elapsed since the last flush. Since we were
waiting for the 'User instance stopped' event to be sent before
calling flush, we might have waited up to 10 seconds before
the event got sent. Instead call the flush right away to send the
stopped and any other remaining events immediately.
We are not actually waiting for the track & identify events anywhere,
so it doesn't make sense to have the method async.
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)