Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Flush instance stopped event immediately #10238

Merged
merged 2 commits into from
Jul 30, 2024
Merged

fix(core): Flush instance stopped event immediately #10238

merged 2 commits into from
Jul 30, 2024

Commits on Jul 30, 2024

  1. fix(core): Flush instance stopped event immediately 

    Rudderstack flushes events after 20 events have been batched or
10 seconds have elapsed since the last flush. Since we were
waiting for the 'User instance stopped' event to be sent before
calling flush, we might have waited up to 10 seconds before
the event got sent. Instead call the flush right away to send the
stopped and any other remaining events immediately.
    @tomi
    tomi committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    2ec86ac View commit details
    Browse the repository at this point in the history

  2. refactor(core): Make telemetry track & identify synchronous 

    We are not actually waiting for the track & identify events anywhere,
so it doesn't make sense to have the method async.
    @tomi
    tomi committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    44d53f2 View commit details
    Browse the repository at this point in the history