Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Remove body padding from storybook previews (no-changelog) #10317

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

mutdmour
Copy link
Contributor

@mutdmour mutdmour commented Aug 7, 2024

Summary

Remove padding from previews, to make it easier to approve Chromatic changes.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@mutdmour mutdmour changed the title fix: Remove padding from storybook previews fix: Remove body padding from storybook previews Aug 7, 2024
@mutdmour mutdmour changed the title fix: Remove body padding from storybook previews fix: Remove body padding from storybook previews (no-changelog) Aug 7, 2024
@mutdmour mutdmour changed the title fix: Remove body padding from storybook previews (no-changelog) fix(design-system): Remove body padding from storybook previews (no-changelog) Aug 7, 2024
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
It's just that design-system is not a valid scope for PR title.

@mutdmour mutdmour changed the title fix(design-system): Remove body padding from storybook previews (no-changelog) fix(editor): Remove body padding from storybook previews (no-changelog) Aug 7, 2024
Copy link

cypress bot commented Aug 7, 2024



Test summary

220 1 0 0Flakiness 1


Run details

Project n8n
Status Failed
Commit 968c247
Started Aug 7, 2024 12:05 PM
Ended Aug 7, 2024 12:10 PM
Duration 04:45 💡
OS Linux Debian -
Browser Electron 118

View run in Cypress Cloud ➡️


Failures

e2e/19-execution.cy.ts Failed
1 Execution > should test webhook workflow stop

Flakiness

e2e/19-execution.cy.ts Flakiness
1 Execution > should test manual workflow stop

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Contributor

github-actions bot commented Aug 7, 2024

✅ All Cypress E2E specs passed

@mutdmour mutdmour merged commit ee968b7 into master Aug 7, 2024
27 of 32 checks passed
@mutdmour mutdmour deleted the fix/storybook-padding branch August 7, 2024 10:52
MiloradFilipovic added a commit that referenced this pull request Aug 7, 2024
* master:
  refactor(core): Centralize scaling mode (no-changelog) (#9835)
  fix(editor): Remove body padding from storybook previews (no-changelog) (#10317)
  feat(MySQL Node): Return decimal types as numbers (#10313)
  🚀 Release 1.54.0 (#10315)
  feat(Elasticsearch Node): Add bulk operations for Elasticsearch (#9940)
  feat(Stripe Trigger Node): Add Stripe webhook descriptions based on the workflow ID and name (#9956)
  feat(MongoDB Node): Add projection to query options on Find (#9972)
  fix(Invoice Ninja Node): Fix payment types (#10196)
  feat(HTTP Request Tool Node): Use DynamicStructuredTool with models supporting it (no-changelog) (#10246)
  feat: Return scopes on executions (no-changelog) (#10310)
  feat(Webflow Node): Update to use the v2 API (#9996)
  feat(Lemlist Trigger Node): Update Trigger events (#10311)
  feat(Calendly Trigger Node): Update event names (no-changelog) (#10129)
  refactor(core): Reorganize webhook related components under src/webhooks (no-changelog) (#10296)
  docs: Fix links to license files in readme (no-changelog) (#10257)
  fix(editor): Update design system Avatar component to show initials also when only firstName or lastName is given (#10308)
  fix(editor): Update tags filter/editor to not show non existing tag as a selectable option (#10297)
  fix(editor): Update project tabs test (no-changelog) (#10300)
  fix(core): VM2 sandbox should not throw on `new Promise` (#10298)

# Conflicts:
#	packages/design-system/src/components/N8nAvatar/Avatar.vue
@janober
Copy link
Member

janober commented Aug 15, 2024

Got released with n8n@1.55.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants