Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Webflow Node): Update to use the v2 API #9996

Merged
merged 10 commits into from
Aug 7, 2024

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Jul 10, 2024

Summary

Updates the Webflow node to use the v2 API.

Tests to follow

Related Linear tickets, Github issues, and Community forum posts

#7052
https://community.n8n.io/t/webflow-integration-isn-t-working/48185/

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request node/new Creation of an entirely new node labels Jul 10, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While manual testing this it seems that V2 doesn't have the right credentials set up

packages/nodes-base/nodes/Webflow/V1/GenericFunctions.ts Outdated Show resolved Hide resolved
packages/nodes-base/nodes/Webflow/V2/methods/index.ts Outdated Show resolved Hide resolved
packages/nodes-base/nodes/Webflow/WebflowTrigger.node.ts Outdated Show resolved Hide resolved
@Joffcom
Copy link
Member Author

Joffcom commented Jul 24, 2024

@ShireenMissi ready for round 2, Removed the oauth selection as that isn't needed so we have the only credential to select and removed the comment for the feature I didn't add

Copy link
Contributor

github-actions bot commented Aug 6, 2024

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Aug 6, 2024



Test summary

389 0 0 0Flakiness 0


Run details

Project n8n
Status Passed
Commit fb8440e
Started Aug 6, 2024 11:53 AM
Ended Aug 6, 2024 11:58 AM
Duration 04:47 💡
OS Linux Debian -
Browser Electron 118

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@Joffcom Joffcom merged commit 6d8323f into master Aug 7, 2024
33 checks passed
@Joffcom Joffcom deleted the node-761-webflow-update-to-v2-api branch August 7, 2024 09:18
@github-actions github-actions bot mentioned this pull request Aug 7, 2024
@janober
Copy link
Member

janober commented Aug 7, 2024

Got released with n8n@1.54.0

MiloradFilipovic added a commit that referenced this pull request Aug 7, 2024
* master:
  refactor(core): Centralize scaling mode (no-changelog) (#9835)
  fix(editor): Remove body padding from storybook previews (no-changelog) (#10317)
  feat(MySQL Node): Return decimal types as numbers (#10313)
  🚀 Release 1.54.0 (#10315)
  feat(Elasticsearch Node): Add bulk operations for Elasticsearch (#9940)
  feat(Stripe Trigger Node): Add Stripe webhook descriptions based on the workflow ID and name (#9956)
  feat(MongoDB Node): Add projection to query options on Find (#9972)
  fix(Invoice Ninja Node): Fix payment types (#10196)
  feat(HTTP Request Tool Node): Use DynamicStructuredTool with models supporting it (no-changelog) (#10246)
  feat: Return scopes on executions (no-changelog) (#10310)
  feat(Webflow Node): Update to use the v2 API (#9996)
  feat(Lemlist Trigger Node): Update Trigger events (#10311)
  feat(Calendly Trigger Node): Update event names (no-changelog) (#10129)
  refactor(core): Reorganize webhook related components under src/webhooks (no-changelog) (#10296)
  docs: Fix links to license files in readme (no-changelog) (#10257)
  fix(editor): Update design system Avatar component to show initials also when only firstName or lastName is given (#10308)
  fix(editor): Update tags filter/editor to not show non existing tag as a selectable option (#10297)
  fix(editor): Update project tabs test (no-changelog) (#10300)
  fix(core): VM2 sandbox should not throw on `new Promise` (#10298)

# Conflicts:
#	packages/design-system/src/components/N8nAvatar/Avatar.vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request node/new Creation of an entirely new node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants