feat(core): Implement wrapping of regular nodes as AI Tools #10641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, any tools connected to the agent wouldn't run with updated parameters. This was because the context would've been cached by the closure in the newly added `supplyData` function. Now, we derive the context and parameters from the passed context.
n8n-assistant
bot
added
core
burivuhster
reviewed
Sep 3, 2024
burivuhster
reviewed
Sep 3, 2024
burivuhster
reviewed
Sep 3, 2024
burivuhster
reviewed
Sep 3, 2024
burivuhster
reviewed
Sep 3, 2024
burivuhster
reviewed
Sep 3, 2024
burivuhster
reviewed
Sep 3, 2024
burivuhster
reviewed
Sep 3, 2024
burivuhster
reviewed
Sep 3, 2024
burivuhster
reviewed
Sep 3, 2024
burivuhster
reviewed
Sep 3, 2024
burivuhster
requested changes
Sep 3, 2024
There was a problem hiding this comment.
Amazing work! 💪
Not sure it is relevant (feel free to discard), but lodash have some utility methods for working with object properties by path (e.g. get, set, toPath, property). Although lodash path format is slightly different for array elements, maybe it is possible to replace some custom code with methods from lodash.
I left some minor comments and questions.
OlegIvaniv
force-pushed
the
ai-284-implement-node-as-tool-wrapper
branch
from
134f288
to
576d601
Compare
OlegIvaniv
commented
Sep 3, 2024
There was a problem hiding this comment.
@burivuhster Thank you for the review! Could you have one more look, please?
burivuhster
approved these changes
Sep 4, 2024
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ai-284-implement-node-as-tool-wrapper
|
| Run status |
|
| Run duration | 04m 47s |
| Commit |
|
| Committer | Oleg Ivaniv |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
422
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Sep 5, 2024
* master: refactor(RabbitMQ Trigger Node): Improve type-safety, add tests, and fix issues with manual triggers (#10663) feat(editor): Add support for nodes with multiple main inputs in new canvas (no-changelog) (#10659) fix(editor): Set minimum zoom to 0 to allow fitting very large workflows in new canvas (no-changelog) (#10666) feat(editor): Change selection to be default canvas behaviour (no-changelog) (#10668) feat: More hints to nodes (#10565) fix(editor): Fix opening executions tab from a new, unsaved workflow (#10652) fix(AI Agent Node): Fix tools agent when using memory and Anthropic models (#10513) feat(editor): Make highlighted data pane floating (#10638) fix(editor): Fix workflow loading after switching to executions view in new canvas (no-changelog) (#10655) refactor(benchmark): Separate cloud env provisioning from running benchmarks (#10657) feat(core): Implement wrapping of regular nodes as AI Tools (#10641) refactor(editor): Remove Trial logic in personalization modal and port to script setup (#10649) fix(core): Declutter webhook insertion errors (#10650) feat: Reintroduce collaboration feature (#10602) feat(benchmark): Add scenario for expressions with Set node (#10647) feat(benchmark): Add benchmark scenario for binary files (#10648) build: Add `reset` script (#10627) feat(editor): Overhaul node insert position computation in new canvas (no-changelog) (#10637)
Merged
|
Got released with |
4 tasks
riascho
pushed a commit
that referenced
this pull request
Sep 23, 2024
Co-authored-by: JP van Oosten <jp@n8n.io>
netroy
reviewed
Oct 15, 2024
| * as an AI Agent Tool. | ||
| * Returns the modified item (not copied) | ||
| */ | ||
| export function convertNodeToAiTool< |
There was a problem hiding this comment.
why did we decide to put this here? can we instead move this to core?
We have way much code in the workflow package. So unless some code actually needs to be shared between backend, frontend, and nodes, we should avoid adding it to this package 🙏🏽
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the ability to wrap regular n8n nodes as AI Tools for use with AI agents. Key changes include:
Added
usableAsToolproperty to node definitions to indicate eligibility for tool wrapping.Implemented
createNodeAsToolfunction:getNodeParameterto integrate LLM-provided values.Modified
NodeExecuteFunctions:getInputConnectionDatato handle tool nodes.supplyDatamethod but is marked as usable as a tool, it creates a wrapper function that callsgetNodeAsTool.Updated
NodeHelperswithconvertNodeToAiToolfunction to modify node descriptions for tool use, including adding a custom description field for LLMs.Right now,
usableAsToolis not set for any of the nodes, we'll enable this in the next phase once we also have placeholder parameters implemented so that LLM could actually pass data to these tools.Example with
usableAsTool: trueand HackerNews node:CleanShot.2024-09-03.at.09.46.53.mp4
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)