Add logging to user management endpoints #2821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
added
feature
|
Closing in favor of #2836, because of too many conflicts. |
| // req.user is empty for public routes, so just proceed | ||
| // owner can do anything, so proceed as well | ||
| if (req.user === undefined || (req.user && (req.user as User).globalRole.name === 'owner')) { | ||
| if (!req.user || (isAuthenticatedRequest(req) && req.user.globalRole.name === 'owner')) { |
There was a problem hiding this comment.
isn't !req.user and isAuthenticatedRequest(req) doing the same thing?
There was a problem hiding this comment.
Not exactly. The type guard specifies not only that req.user is not undefined but also that req.user is of type User, which allows for role access without the assertion. Without the type guard, in the second half we know that req.user is not undefined but not what type it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP