Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging to user management endpoints #2821
Add logging to user management endpoints #2821
Changes from all commits
9e09621
2fecf12
c374832
4a0c890
033ca8b
9e1d587
ea99936
efef70c
528a140
b3bc597
b87fdfa
9188738
4d09435
d831071
0d5bef0
7875dba
bdd8ca2
9e8ccb6
7c0110e
dbdd54a
b9e21f7
cdf8105
694a502
b6354b4
8e4eb41
3f41dd6
70f3a66
efc6d2b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't
!req.user
andisAuthenticatedRequest(req)
doing the same thing?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not exactly. The type guard specifies not only that
req.user
is notundefined
but also thatreq.user
is of typeUser
, which allows for role access without the assertion. Without the type guard, in the second half we know thatreq.user
is notundefined
but not what type it is.